Feat: Implement tracing for tool execution#453
Closed
AmaadMartin wants to merge 2 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
Problem:
Tool execution in
adk-jswas not traced, making it difficult to debug tool calls and performance in production.Solution:
Wrapped tool execution inside
handleFunctionCallListwith OpenTelemetry spans. InlinedcallToolAsyncand simplified event building to ensure the span covers the entire tool execution lifecycle (including callbacks and plugins). Recorded exceptions to the span and set span status to ERROR when appropriate.Testing Plan
Unit Tests:
Summary of passed npm test results:
Manual End-to-End (E2E) Tests:
N/A
Checklist
Additional context
N/A