fix(skilltoolset): align load_skill instruction with schema#1033
Open
KirtiRamchandani wants to merge 1 commit into
Open
fix(skilltoolset): align load_skill instruction with schema#1033KirtiRamchandani wants to merge 1 commit into
KirtiRamchandani wants to merge 1 commit into
Conversation
The default system instruction told models to call load_skill with skill_name=, but LoadSkillArgs expects name=. Update the instruction and document load_skill_resource parameters explicitly. Fixes google#912
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SkillToolsetsystem instruction to callload_skillwithname="<SKILL_NAME>"instead of the incorrectskill_name=load_skill_resourceparameters explicitly (skill_name+resource_path) so both tools' argument names are clearFixes #912
Test plan
go test ./tool/skilltoolset/... -count=1/cc @indurireddy-TF