Fix the code sample of using BigQuery with the application default credentails #825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koverholt
approved these changes
Oct 27, 2025
There was a problem hiding this comment.
Thanks for the contribution and clarification! 🎉
I left an optional comment in case you have better wording for the comment about why we want to use BigQueryCredentialsConfig() without arguments here. But the more important change is getting the code right, so I'm approving and it LGTM as-is.
cc @joefernandez for review as well
joefernandez
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code incorrectly gets the auth token at the time the toolset is created. Once the token expires, the authentication will stop working