Remove gemminc kernels #8246
Open
Remove gemminc kernels #8246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
These are unused currently, not hooked up to any configs. We are very interested in tiling the K dimension of gemms, which these kernels would be helpful with. However, it's not clear that these are on the critical path to doing this: - This approach doesn't generalize beyond fp32 accumulators. - There are some issues with these kernels that are likely undiscovered because this code is unused (e.g. min/max is applied at every tile of K, could use multiple different params to work around of course, but I think this just hasn't been thought about yet, and there are probably many other things like that). - Packing that exists currently is not compatible with existing packing approaches, and would need quite a bit of work to get it up to speed. If we do end up wanting these kernels, we can always revert this change. But as it stands, these kernels have been unused for years, and are unlikely to be used in the future. PiperOrigin-RevId: 746084904
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove gemminc kernels
These are unused currently, not hooked up to any configs.
We are very interested in tiling the K dimension of gemms, which these kernels would be helpful with. However, it's not clear that these are on the critical path to doing this:
If we do end up wanting these kernels, we can always revert this change. But as it stands, these kernels have been unused for years, and are unlikely to be used in the future.