This repository was archived by the owner on Dec 16, 2025. It is now read-only.
change the test constructor to allow injecting an http engine to allo…#211
Open
davidmotson wants to merge 2 commits intomainfrom
Open
change the test constructor to allow injecting an http engine to allo…#211davidmotson wants to merge 2 commits intomainfrom
davidmotson wants to merge 2 commits intomainfrom
Conversation
…w more configuration of the mockengine
Collaborator
|
I don't think the test constructor is needed anymore. Reverting fa9688a should achieve what you're looking for. |
Contributor
Author
I don't think that's sufficient, the public constructor does not allow me to pass an http engine, that constructor is internal only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…w more configuration of the mockengine