This repository was archived by the owner on Dec 16, 2025. It is now read-only.
Enhance enum serialization with nullability, @SerialName support, caching and informative logging. #183
Open
karloti wants to merge 3 commits intogoogle-gemini:mainfrom
Open
Enhance enum serialization with nullability, @SerialName support, caching and informative logging. #183karloti wants to merge 3 commits intogoogle-gemini:mainfrom
karloti wants to merge 3 commits intogoogle-gemini:mainfrom
Conversation
Introduce enumSerializer function toprovide a more type-safe and concise way to serialize enums. This new approach supports nullable enums (EnumClass?) and eliminates the need for custom enum serializers. Deprecate FirstOrdinalSerializer in favor of enumSerializer, as it offers better type safety and nullability handling. Update usage to reflect the newrecommended approach. This change improves the robustness and maintainability of enum serialization within the project.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Introduce enumSerializer to provide type-safe, efficient enum serialization with support for nullable enums, custom enum names using @SerialName, and optimized lookups through caching. Deprecate FirstOrdinalSerializer, which lacked these features and could lead to issues with evolving backend APIs.
The new approach gracefully handles unknown enum values by returning null and logging a message, encouraging developers to update the SDK or report the issue. Caching enum lookups ensures O(1) complexity for serialization and deserialization, significantly improving performance.
enum class Country and data class Person
Unknown enum value found: "FRANCE" in Country
This usually means the backend was updated, and the SDK needs to be updated to match it.
Check if there's a new version for the SDK, otherwise please open an issue on our
GitHub to bring it to our attention:
https://github.com/google/google-ai-android
tests