Feature: Added a demo for learnlm model#744
Merged
Giom-V merged 16 commits intogoogle-gemini:mainfrom Jun 4, 2025
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
github-actions
Bot
added
status:awaiting review
Collaborator
Author
nikitamaia
reviewed
Apr 30, 2025
Collaborator
|
@andycandy this is great! I added a few minor comments to clarify some of the markdown instructions. |
Collaborator
Author
|
@nikitamaia thank you for the feedback, I'll work on those suggestions now |
Giom-V
requested changes
May 6, 2025
Collaborator
Giom-V
left a comment
Giom-V
left a comment
There was a problem hiding this comment.
@andycandy I was about to merge the PR, but saw some minor stuff that I won't be easily able to change in a subsequent CL:
- Can you rename the file "Get_started_LearnLM.ipynb to stay consistent with the other get started guides? That was the blocking one
- Can you copy and adapt to yourself the contributor badge I'm introducing in https://github.com/Giom-V/gemini-api-cookbook/blob/badges/examples/Virtual_Try_On.ipynb ?
- While you're at it, I would also move the "Help me study for a undergrad cognition test on theories of emotion generation" prompt to the cell below where it is.
Collaborator
|
@andycandy You also need to update the quickstarts readme to add a link to the notebook (maybe not the main one as it's not a new model) |
Collaborator
Author
|
On it @Giom-V! |
Collaborator
Author
|
Done! |
Giom-V
previously approved these changes
May 6, 2025
link fix
This reverts commit f10ae03. reverting
Giom-V
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #732
Get_Started_Learnlmnotebook in quickstarts folder