-
Notifications
You must be signed in to change notification settings - Fork 111
Address Warp Deprecation Warnings #981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
c9ba316
d785d3c
78ea7aa
83acab4
07d8221
4add9ed
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,7 +29,7 @@ dependencies = [ | |
| "etils[epath]", | ||
| "mujoco>=3.3.7", | ||
| "numpy", | ||
| "warp-lang>=1.9.1", | ||
| "warp-lang>=1.11.0", | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do we need these changes? we should only change this if mjwarp no longer works with
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's correct. For example, the current MR replaces internal references like: with: The latter was introduced as part of the public API overhaul commit 2d6d379a, and released in v1.11.0. This MR also uses
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah OK, understood. SGTM. |
||
| ] | ||
|
|
||
| [[tool.uv.index]] | ||
|
|
@@ -55,7 +55,7 @@ dev = [ | |
| "pygls>=1.0.0,<2.0.0", | ||
| "lsprotocol>=2023.0.1,<2024.0.0", | ||
| "mujoco>=3.3.7.dev0", | ||
| "warp-lang>=1.9.1.dev0", | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We put this here because when we develop, we want to use a Warp nightly. Please revert this change.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done! ✔️ |
||
| "warp-lang>=1.11.0.dev0", | ||
| ] | ||
| # TODO(team): cpu and cuda JAX optional dependencies are temporary, remove after we land MJX:Warp | ||
| cpu = [ | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.