Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual Settings not respected when starting a new beatmap #6

Closed
LeNitrous opened this issue Apr 20, 2021 · 1 comment
Closed

Visual Settings not respected when starting a new beatmap #6

LeNitrous opened this issue Apr 20, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@LeNitrous
Copy link

LeNitrous commented Apr 20, 2021 •
edited
Loading

Awesome recreation! I'm enjoying it so far. Though what onlyirks me so far is the kiai visualizer and input display not respecting the setting everytime I start a new beatmap. A quick fix to this is setting the last argument of BindValueChanged to true so the action on the former argument should run at least once.

soyokaze/osu.Game.Rulesets.Soyokaze/UI/SoyokazePlayfield.cs

Line 62 in 2e66415

showInputOverlayBindable.BindValueChanged(valueChanged => inputOverlay.FadeTo(valueChanged.NewValue ? 1f : 0f, 300.0));

soyokaze/osu.Game.Rulesets.Soyokaze/UI/SoyokazePlayfield.cs

Line 64 in 2e66415

showKiaiVisualizerBindable.BindValueChanged(valueChanged => kiaiVisualizer.FadeTo(valueChanged.NewValue ? 1f : 0f, 300.0));

goodtrailer added a commit that referenced this issue Apr 20, 2021
@goodtrailer
Respect visual settings when starting a new beatmap
21d150b 
Fixed issue #6.
Moved visibility bindings out of SoyokazePlayfield and into their
respective classes, SkinnableInputOverlay and SkinnableKiaiVisualizer.
@goodtrailer
Copy link
Owner

Derp, thanks for notifying me about this. Should be fixed now.

@goodtrailer goodtrailer added the bug Something isn't working label Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LeNitrous @goodtrailer