Skip to content

Commit

Permalink
VS and CodeFactor code cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
goodtrailer committed Apr 9, 2021
1 parent 85ef21c commit 2e66415
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ public static Vector2[] GetPositions(int screenCenterDistance, int gap, bool inB
new Vector2(offset.X + screenCenterDistance + gap, offset.Y )
};


if (!inButtonOrder)
return positions;
else
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ private void updatePositions()
Vector2[] positions = PositionExtensions.GetPositions(screenCenterDistance, gap, true, Anchor.Centre);
for (int i = 0; i < 8; i++)
inputOverlayKeys[i].Position = positions[i];

inputOverlayBackgrounds[0].Position = new Vector2(-screenCenterDistance, 0);
inputOverlayBackgrounds[1].Position = new Vector2(screenCenterDistance, 0);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ private void load(ISkinSource skin)
AddInternal(composite);

Color4 defaultColor = skin.GetConfig<SoyokazeSkinColour, Color4>(SoyokazeSkinColour.KiaiVisualizerDefault)?.Value ?? Color4.DarkSlateGray;
byte defaultOpacity= skin.GetConfig<SoyokazeSkinConfiguration, byte>(SoyokazeSkinConfiguration.KiaiVisualizerDefaultOpacity)?.Value ?? 128;
byte defaultOpacity = skin.GetConfig<SoyokazeSkinConfiguration, byte>(SoyokazeSkinConfiguration.KiaiVisualizerDefaultOpacity)?.Value ?? 128;
composite.Colour = defaultColor.Opacity(defaultOpacity);

firstFlashColour = skin.GetConfig<SoyokazeSkinColour, Color4>(SoyokazeSkinColour.KiaiVisualizerFirstFlash)?.Value ?? Color4.White;
firstFlashOpacity = skin.GetConfig<SoyokazeSkinConfiguration, byte>(SoyokazeSkinConfiguration.KiaiVisualizerFirstFlashOpacity)?.Value ?? 255;

Expand Down
4 changes: 0 additions & 4 deletions osu.Game.Rulesets.Soyokaze/Skinning/SoyokazeSkinColour.cs
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
// Copyright (c) Alden Wu <[email protected]>. Licensed under the MIT Licence.
// See the LICENSE file in the repository root for full licence text.

using System;
using System.Collections.Generic;
using System.Text;

namespace osu.Game.Rulesets.Soyokaze.Skinning
{
public enum SoyokazeSkinColour
Expand Down
1 change: 0 additions & 1 deletion osu.Game.Rulesets.Soyokaze/UI/SoyokazePlayfield.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// See the LICENSE file in the repository root for full licence text.

using osu.Framework.Allocation;
using osu.Framework.Audio.Track;
using osu.Framework.Bindables;
using osu.Framework.Graphics;
using osu.Framework.Graphics.Containers;
Expand Down

0 comments on commit 2e66415

Please sign in to comment.