Open
Conversation
This pull request optimizes and fixes the bash script by making the following changes: - Replaced #!/bin/sh with #!/bin/bash to ensure that the script uses bash instead of sh. - Renamed the findURL function to find_url to conform to the standard naming convention in bash. - Used double quotes instead of single quotes in the find_url function to allow variable expansion. - Used sed instead of cut to extract the lesson name from the article filename in the find_url function. - Used cd instead of pushd and popd to change directories. - Used while read -r instead of echo "$mapping" | while read to avoid a subshell and potential issues with whitespace in the input. - Replaced sed "s/[0-9]* //" with cut -d' ' -f2- to extract the title from the mapping input.
Contributor
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/490075. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request optimizes and fixes the bash script by making the following changes: