Repository navigation
Conversation
CL 89936 introduced restriction that Rows.Close() shouldn't modify dest in previous Next(). CL 497675 for golang#60304 removed that restriction. But it didn't remove doc about the restriction.
Contributor
|
This PR (HEAD: f37493a) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/670895. Important tips:
|
gopherbot
pushed a commit
that referenced
this pull request
Jul 23, 2026
CL 89936 introduced restriction that Rows.Close() shouldn't modify dest in previous Next(). CL 497675 for #60304 removed that restriction. But it didn't remove doc about the restriction. Change-Id: Idc0f16462fba4d2013ec069d251b8ebffbc4bdd1 GitHub-Last-Rev: f37493a GitHub-Pull-Request: #73632 Reviewed-on: https://go-review.googlesource.com/c/go/+/670895 Auto-Submit: Sean Liao <sean@liao.dev> Reviewed-by: Sean Liao <sean@liao.dev> Reviewed-by: David Chase <drchase@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Carlos Amedee <carlos@golang.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CL 89936 introduced restriction that Rows.Close() shouldn't modify dest
in previous Next().
CL 497675 for #60304 removed that restriction. But it didn't remove doc
about the restriction.