Fix Clickhouse driver to work correctly with v2 #950
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jhzn please check why tests are broken for go 1.20 |
The failing tests are for |
Working now 👍 |
obalunenko
approved these changes
Jan 11, 2024
|
@dhui could you please take a look on this PR, when you have a chance? 🙏 |
|
@dhui Could you please take a look at this PR? 🙏 |
|
Seems to work fine in the latest release. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated this PR: #723
I'm not the original author. I've only updated his/her code with the latest master in hope of getting it merged.
Credit goes to: @lo00l