fix for create table engine ReplicatedReplacingMergeTree

[Rupreht]

Fix for x-migrations-table-engine=ReplicatedReplacingMergeTree

2024/09/18 22:32:32 error: failed to open database, "clickhouse://localhost:9440/?username=xxx&password=xxx&secure=1&skip_verify=1&debug=1&x-migrations-table=MIGRATE_SCHEMA_MIGRATIONS&x-migrations-table-engine=ReplicatedReplacingMergeTree('/clickhouse/tables/xxx/MIGRATE_SCHEMA_MIGRATIONS','{replica}')&x-cluster-name=xxxx":
 code: 42, message: There was an error on [chi-replicated-xxxx-0-0:9440]:
Code: 42. DB::Exception: ORDER BY or PRIMARY KEY clause is missing.
Consider using extended storage definition syntax with ORDER BY or PRIMARY KEY clause.

this patch makes so:

CREATE TABLE MIGRATE_SCHEMA_MIGRATIONS ON CLUSTER otel (
   version    Int64,
   dirty      UInt8,
   sequence   UInt64
) Engine=ReplicatedReplacingMergeTree('/clickhouse/tables/otel/MIGRATE_SCHEMA_MIGRATIONS','{replica}')
PRIMARY KEY sequence
ORDER BY sequence

[Rupreht]

you can connect to any nodes in cluster and deploy everything at once
p/s
the broken test in 1.22.x is not because of database/clickhouse/clickhouse.go (my patch)

[nielsreijers]

Any idea if/when this will be merged? The failing test does indeed seem unrelated.
I was about to open a PR for exactly the same change since I need to set a Zookeeper path on my ReplicatedMergeTree, which doesn't work without this change.

Good to see I'm not alone in this. :-)