Feature/otp 27 upgrade #72

yashGojek · 2025-02-25T22:09:50Z

Proposed Changes

Updated OTP version to 27.0
Fixed unable to stop application using bin/vernemq stop command( Ref. - Vanilla repo mr
Fixed unable to connect client to vernemq (Ref. - Vanilla repo mr

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

[] Bugfix (non-breaking change which fixes issue #XXXX)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation (correction or otherwise)
Cosmetics (whitespace, styles...)
DevOps (Build scripts, pipelines...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

I have read the CODE_OF_CONDUCT.md document
All tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if needed)
Any dependent changes have been merged and published in related repositories
I have updated changelog (At the bottom of the release version)
I have squashed all my commits into one before merging

Further Comments

If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.

chore: remove unwanted changes

Reference: vernemq#2103

VivekPipaliya23 · 2025-04-14T05:25:06Z

apps/.DS_Store

why do we need this file?

VivekPipaliya23 · 2025-04-14T05:25:28Z

apps/vmq_commons/.DS_Store

why do we need this file?

VivekPipaliya23 · 2025-04-14T05:32:01Z

apps/vmq_server/test/vmq_cluster_test_utils.erl

@@ -20,21 +20,10 @@

 -module(vmq_cluster_test_utils).

-export([


can we restore the previous formatting to easily get the actual diff?

VivekPipaliya23 · 2025-04-14T05:33:07Z

apps/vmq_server/test/vmq_connect_SUITE.erl

@@ -328,4 +329,4 @@ start_listener(Config) ->
 ssl_path(File) ->
    Path = filename:dirname(
             proplists:get_value(source, ?MODULE:module_info(compile))),
-    filename:join([Path, "ssl", File]).
+    filename:join([Path, "ssl", File]).


please add the EOF line.

VivekPipaliya23 · 2025-04-14T05:33:12Z

apps/vmq_server/test/vmq_http_SUITE.erl

@@ -39,4 +39,4 @@ simple_healthcheck_test(_) ->
    application:ensure_all_started(inets),
    {ok, {_Status, _Headers, Body}} = httpc:request("http://localhost:8888/health"),
    JsonResponse = jsx:decode(list_to_binary(Body), [return_maps, {labels, binary}]),
-    <<"OK">> = maps:get(<<"status">>, JsonResponse).
+    <<"OK">> = maps:get(<<"status">>, JsonResponse).


please add the EOF line.

VivekPipaliya23 · 2025-04-14T05:33:22Z

apps/vmq_server/test/vmq_metrics_SUITE.erl

@@ -235,4 +235,4 @@ histogram_systree_test(_Cfg, Suffix, Val) ->
    Publish = packet:gen_publish(PublishTopic, 0, integer_to_binary(Val), []),
    ok = packet:expect_packet(SubSocket, "publish", Publish),
    gen_tcp:send(SubSocket, packet:gen_disconnect()),
-    gen_tcp:close(SubSocket).
+    gen_tcp:close(SubSocket).


please add the EOF line.

VivekPipaliya23 · 2025-04-14T05:33:37Z

apps/vmq_server/test/vmq_test_utils.erl

@@ -136,4 +136,4 @@ seed_rand(Config) ->

 rand_bytes(N) ->
    L = [ rand:uniform(256)-1 || _ <- lists:seq(1,N)],
-    list_to_binary(L).
+    list_to_binary(L).


please add the EOF line.

VivekPipaliya23 · 2025-04-14T05:34:01Z

apps/vmq_webhooks/test/vmq_webhooks_SUITE.erl

@@ -547,4 +548,4 @@ exp_nothing(Timeout) ->
            ok
    end.

-
+


please add the EOF line.

VivekPipaliya23 · 2025-04-14T05:36:11Z

docker/Dockerfile


 RUN apk --no-cache --update --available upgrade && \
-    apk add --no-cache ncurses-libs openssl libstdc++ jq curl bash snappy-dev && \
+    apk add --no-cache ncurses openssl libstdc++ jq curl bash snappy libgcc libc6-compat && \


any reason for updating ncurses-libs and snappy-dev?

VivekPipaliya23 · 2025-04-14T05:36:34Z

run-tests-with-retry.sh

      (echo -e "\nContents of retry.spec\n" &&
      cat $FULLPATH &&
      echo -e "\nRetry suites:" &&
      echo $(pcregrep -o2 -o3 --om-separator="/" -M "^{(cases|groups),\"(.+)\",[^\w]*(\w+),(.|\n)*?\.$" $FULLPATH | uniq | paste -s -d, -) &&
      make db-reset &&
-      ./rebar3 ct --suite=$(pcregrep -o2 -o3 --om-separator="/" -M "^{(cases|groups),\"(.+)\",[^\w]*(\w+),(.|\n)*?\.$" $FULLPATH | uniq | paste -s -d, -))
+      ./rebar3 ct --suite=$(pcregrep -o2 -o3 --om-separator="/" -M "^{(cases|groups),\"(.+)\",[^\w]*(\w+),(.|\n)*?\.$" $FULLPATH | uniq | paste -s -d, -))


please add the EOF line.

VivekPipaliya23 · 2025-04-14T05:45:07Z

Can you include vanilla Vernemq PR or reference alongside the commit link where you made the specified fix/change in this PR description?

VivekPipaliya23 · 2025-04-14T05:49:50Z

.github/workflows/pr.yml

+      - run: make rel
+      # - run: make db-setup
+      - run: pwd
+      - run: sh ./run-tests-with-retry.sh .


please add the EOF line.

VivekPipaliya23 · 2025-04-14T08:30:17Z

rebar.config

@@ -38,16 +36,17 @@
 ]}.

 {deps, [
-    {recon, "2.5.1"},
-    {lager, "3.8.0"},


why are we removing lager?

VivekPipaliya23 · 2025-04-14T08:34:34Z

rebar.config

@@ -121,7 +119,7 @@
        {mkdir, "data/msgstore"},
        {mkdir, "log/sasl"},

-        {copy, "_build/default/bin/psql_migration", "bin/psql_migration"},
+        % {copy, "_build/default/bin/psql_migration", "bin/psql_migration"},


If this is not required, then remove this from the comments as well.

VivekPipaliya23 · 2025-04-14T08:40:40Z

apps/vmq_plumtree/rebar.config

-    {plumtree, {git, "https://github.com/vernemq/plumtree.git", {branch, "master"}}}
+    {plumtree,
+        {git, "https://github.com/vernemq/plumtree.git",
+            {ref, "e91404882281ea66f40de8bac671a50f44da069b"}}}


why are we using a specific commit rather than master?
I can see that the commit id used is the same as the master.

VivekPipaliya23 · 2025-04-14T09:54:22Z

apps/vmq_server/priv/vmq_server.schema

@@ -762,7 +762,7 @@
 [
  {default, "3,4,131"},
  {datatype, string},
-  {commented, "3,4"}
+  {commented, "3,4,5"}


are we adding support for the MQTT 5 protocol?

VivekPipaliya23 · 2025-04-14T10:34:53Z

apps/vmq_server/priv/vmq_server.schema

@@ -637,7 +637,7 @@
 %% - listener.wss.default = 127.0.0.1:880
 {mapping, "listener.tcp.$name", "vmq_server.listeners", [
                                                            {default, { "{{mqtt_default_ip}}", {{mqtt_default_port}} }},
-                                                            {datatype, ip},
+                                                            {datatype, [ip]},


Do we require this change for the OTP update?

VivekPipaliya23 · 2025-04-14T10:50:19Z

apps/vmq_commons/src/packet.erl

@@ -32,7 +32,7 @@
 expect_packet(Socket, Name, Expected) ->
    expect_packet(gen_tcp, Socket, Name, Expected).
 expect_packet(Transport, Socket, Name, Expected) ->
-    expect_packet(Transport, Socket, Name, Expected, 5000).
+    expect_packet(Transport, Socket, Name, Expected, 15000).


is this required?

Yash Kumar added 3 commits February 20, 2025 04:14

feature: OTP version upgrade to 27

d885620

fix: remove log format file and update dependency url for eleveldb

a3fcc1a

fix: unable to stp application and unable to subscribe

d35a992

yashGojek requested a review from dhruvjain99 February 25, 2025 22:09

Yash Kumar and others added 26 commits February 26, 2025 03:58

chore: formatting fix

0f3ac3e

test: fix test method deprecations

5ee3755

feature: test build on different os and OTP versions

5ce541a

test: fix tests breaking due to ordering

aec35e7

chore: skip make db-setup for build to pipeline to run

12428c9

chore: formatting fix

0501a38

ignore dialyzer results

a689c48

test: jwerl url update

15e14b6

test: fix vmq_diversity suites

749d67c

test: fixed test suites and cluster suite WIP

2bc870c

test: fix breaking test suites

55729d3

chore: remove unwanted changes

test: fix breaking suites

ec75ea7

disabling dialyzer again

9a3b6fc

fix: multiple test fix

ca0b157

chore: typo fix

efae016

WIP try coverage on ubuntu 22.04

ef168f5

test: fix simple_prometheus_test testcase

5d13598

fix: fixed postgres breaking test and removed OTP 23 from pr checks

5d20471

chore: formatting fix

a69bc37

fix: eccs testcase fix for vmq_schema_SUITE

3a9ea5a

Reference: vernemq#2103

fix: ignore dialyzer in rebar config

cfd1190

fix: remove clique overrride

458e6b6

chore: remove fail on warnings

f6e76e2

fix: depenedency update for sidecar

3812a8d

chore: cleanup

ad337e3

fix: remove unwanted lock file in apps

e31481e

yashGojek added 8 commits April 8, 2025 13:18

fix: add libraries missing in otp 27 alpine image

6b0722b

fix: add libraries missing in otp 27 alpine image

3df4242

fix: add libraries missing in otp 27 alpine image

df5a991

fix: add libraries missing in otp 27 alpine image

c5b52dc

fix: upgrade alpine version

c982712

fix: listener show cmd error

6c6e5ef

fix: listener func issue

aa2c136

fix: listener fix for sidecar

bb9f725