fix(ci): added pragma to dagger functions to pass a default directory to the source flag#699
Open
rkcoder101 wants to merge 1 commit intogoharbor:mainfrom
Open
fix(ci): added pragma to dagger functions to pass a default directory to the source flag#699rkcoder101 wants to merge 1 commit intogoharbor:mainfrom
rkcoder101 wants to merge 1 commit intogoharbor:mainfrom
Conversation
…he source flag Signed-off-by: Rayyan Khan <rayyanrehman101@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Dagger pipeline entrypoints so the source *dagger.Directory argument defaults to the repository root (and respects .gitignore), making --source no longer necessary for common dagger call invocations (per #696).
Changes:
- Added Dagger parameter pragmas
// +ignore=[".gitignore"]and// +defaultPath="."tosourcearguments. - Applied the change across the lint, test, vuln-check, docs, and dev-build Dagger functions.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.dagger/vuln.go |
Adds default source directory + ignore rules to vulnerability check functions. |
.dagger/test.go |
Adds default source directory + ignore rules to test and coverage functions. |
.dagger/lint.go |
Adds default source directory + ignore rules to lint functions. |
.dagger/doc.go |
Adds default source directory + ignore rules to doc generation function. |
.dagger/buildDev.go |
Adds default source directory + ignore rules to the dev build function. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@bupd @NucleoFusion can we merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #696