fix(prompt): remove GetTagNameFromUser() that caused deadlock#681
Open
rshdhere wants to merge 3 commits intogoharbor:mainfrom
Open
fix(prompt): remove GetTagNameFromUser() that caused deadlock#681rshdhere wants to merge 3 commits intogoharbor:mainfrom
rshdhere wants to merge 3 commits intogoharbor:mainfrom
Conversation
rshdhere
force-pushed
the
fix/deadlock-in-prompt
branch
from
3070b64 to
f8001bf
Compare
Author
|
PTAL @NucleoFusion |
qcserestipy
requested changes
Feb 7, 2026
Collaborator
qcserestipy
left a comment
qcserestipy
left a comment
There was a problem hiding this comment.
Thank you for this contribution. I think the comment might be removed. Otherwise LGTM
pkg/prompt/prompt.go
Outdated
|
|
||
| return <-repoName | ||
| } | ||
| // GetTagNameFromUser was removed - it contained a deadlock bug (empty goroutine |
Collaborator
There was a problem hiding this comment.
I think we can remove it without leaving a comment. So far no one used it and will not miss it, I guess
Author
There was a problem hiding this comment.
sorry for the delay was busy with school, on it now!
The function had an empty goroutine that never sent to the unbuffered channel, causing any caller to block indefinitely. Since this function was unused and GetTagFromUser() already provides the correct implementation for tag selection, removing it entirely is the cleanest fix. Fixes goharbor#680 Signed-off-by: raashed <mohammedraashed10@gmail.com>
- Eliminate `GetTagNameFromUser` containing empty goroutine that never sent to channel, causing deadlock[1][2] - Retain `GetTagFromUser` as corrected replacement that properly fetches and displays tags[1] Signed-off-by: raashed <mohammedraashed10@gmail.com>
Signed-off-by: raashed <mohammedraashed10@gmail.com>
rshdhere
force-pushed
the
fix/deadlock-in-prompt
branch
from
a342949 to
383c254
Compare
Author
|
rebased and ready to be merged @qcserestipy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solves #680
The function had an empty goroutine that never sent to the unbuffered channel, causing any caller to block indefinitely. Since this function was unused and GetTagFromUser() already provides the correct implementation for tag selection, removing it entirely is the cleanest fix. Fixes #680