fix: return errors in user elevate command to prevent silent failures#661
Open
samruddhi-Rahegaonkar wants to merge 2 commits intogoharbor:mainfrom
Open
fix: return errors in user elevate command to prevent silent failures#661samruddhi-Rahegaonkar wants to merge 2 commits intogoharbor:mainfrom
samruddhi-Rahegaonkar wants to merge 2 commits intogoharbor:mainfrom
Conversation
samruddhi-Rahegaonkar
force-pushed
the
fix-error-handling-655
branch
from
5b2b418 to
d0f3692
Compare
Author
|
@bupd please review this. |
samruddhi-Rahegaonkar
force-pushed
the
fix-error-handling-655
branch
from
053ca78 to
68fffe8
Compare
Signed-off-by: Samruddhi Rahegaonkar <rsamruddhi21@gmail.com>
Signed-off-by: Samruddhi Rahegaonkar <rsamruddhi21@gmail.com>
samruddhi-Rahegaonkar
force-pushed
the
fix-error-handling-655
branch
from
68fffe8 to
9976d6b
Compare
Author
|
@bupd @qcserestipy I’ve updated the PR to focus on a centralized logging and error-handling approach rather than a command-specific fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR fixes improper error handling in the
user elevatecommand.Previously, errors were logged using
log.Errorfwithout returning, causing the CLI to continue execution with invalid state and exit successfully even after critical failures.The command now uses Cobra’s
RunEpattern and returns errors immediately, ensuring correct exit behavior and preventing silent failures.Related issue
Fixes #655