fix(member): handle error in DeleteAllMember to prevent nil pointer p…#660
Open
goyalpalak18 wants to merge 2 commits intogoharbor:mainfrom
Open
fix(member): handle error in DeleteAllMember to prevent nil pointer p…#660goyalpalak18 wants to merge 2 commits intogoharbor:mainfrom
goyalpalak18 wants to merge 2 commits intogoharbor:mainfrom
Conversation
Author
|
Hi @bupd! Could you please review this fix for the nil pointer panic? Thanks! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #660 +/- ##
=========================================
- Coverage 10.99% 7.17% -3.82%
=========================================
Files 173 260 +87
Lines 8671 12854 +4183
=========================================
- Hits 953 922 -31
- Misses 7612 11824 +4212
- Partials 106 108 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…anic Signed-off-by: goyalpalak18 <goyalpalak1806@gmail.com>
Signed-off-by: goyalpalak18 <goyalpalak1806@gmail.com>
709d696 to
28a10a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I ran into a crash when using
harbor project member delete --allwhile my Harbor credentials were expired.Instead of telling me the request failed, the CLI panicked with a nil pointer dereference. It turns out the
DeleteAllMemberfunction was ignoring errors from the API and trying to read the empty response anyway.This PR fixes that by adding proper error checking. Now, if the API call fails (network timeout, 401, etc.), the CLI will print a readable error message and exit cleanly instead of crashing with a stack trace.
Verification
I reproduced this by simulating a network error during the delete command.
runtime error: invalid memory address.failed to list members: connection refusedand exited with code 1.Checklist