Open
Conversation
Signed-off-by: dhruv <dhruvtotla30@gmail.com> Fix: return errors instead of continuing after log.Errorf CLI commands were continuing execution after logging errors, leading to invalid or empty state. This change ensures errors are returned immediately and execution stops as expected. Signed-off-by: Dhruv Totala <dhruvtotla30@gmail.com>
DhruvTotala
force-pushed
the
issue-655-error-handling
branch
from
c437ac2 to
9eea30c
Compare
|
@DhruvTotala i have opened a pr #656 . why are you opening a new one ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #655, where some CLI commands continued executing after an error was logged using log.Errorf(). Because the error was not returned, the command would proceed with empty or invalid values, leading to silent and confusing failures.
What has changed:-
These changes make the CLI behavior more predictable and align error handling with standard Cobra CLI practices.