-
-
Notifications
You must be signed in to change notification settings - Fork 494
Update auth-jwt README: change registration endpoint to /user #3328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. |
Summary of ChangesHello @StefSchalks, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on maintaining accurate documentation by updating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
WalkthroughDocumentation update in auth-jwt/README.md: the example registration endpoint was changed from /api/auth/register to /api/user in usage snippet and API Endpoints list. No code, logic, or control flow changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the user registration endpoint in the auth-jwt README example. The change correctly aligns the example with the router's implementation. However, it introduces an inconsistency, as the API endpoint list in the same file was not updated. I've added a comment suggesting a fix to ensure the documentation is fully consistent.
| 1. Register a new user: | ||
| ```bash | ||
| curl -X POST http://localhost:3000/api/auth/register -d '{"username":"testuser", "password":"testpassword", "email":"[email protected]"}' -H "Content-Type: application/json" | ||
| curl -X POST http://localhost:3000/api/user -d '{"username":"testuser", "password":"testpassword", "email":"[email protected]"}' -H "Content-Type: application/json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this change correctly updates the example to use the /api/user endpoint, it creates an inconsistency within the README. The 'API Endpoints' list (line 65) still refers to the old /api/auth/register endpoint, and line 68 also lists /api/user.
For clarity and consistency, please update the API endpoints list to remove the incorrect /api/auth/register entry and clarify that POST /api/user is for user registration.
…user
Summary by CodeRabbit