-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump github.com/valyala/fasthttp from 1.57.0 to 1.58.0 #3244
build(deps): bump github.com/valyala/fasthttp from 1.57.0 to 1.58.0 #3244
Conversation
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50
.
Benchmark suite | Current: 3ad8c74 | Previous: e9849b7 | Ratio |
---|---|---|---|
Benchmark_Compress_Levels/Brotli_LevelBestCompression - B/op |
6 B/op |
0 B/op |
+∞ |
This comment was automatically generated by workflow using github-action-benchmark.
This update is causing a legit failure: === Failed
=== FAIL: middleware/session Test_Session_Middleware (0.00s)
middleware_test.go:171:
Error Trace: /Users/runner/work/fiber/fiber/middleware/session/middleware_test.go:171
Error: "session_id=; max-age=0; path=/; SameSite=Lax" does not contain "expires="
Test: Test_Session_Middleware |
3ad8c74
to
744914a
Compare
This must be related to changes introduced here: |
Bumps [github.com/valyala/fasthttp](https://github.com/valyala/fasthttp) from 1.57.0 to 1.58.0. - [Release notes](https://github.com/valyala/fasthttp/releases) - [Commits](valyala/fasthttp@v1.57.0...v1.58.0) --- updated-dependencies: - dependency-name: github.com/valyala/fasthttp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
744914a
to
054cc4e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3244 +/- ##
==========================================
+ Coverage 82.69% 82.76% +0.07%
==========================================
Files 115 115
Lines 11383 11383
==========================================
+ Hits 9413 9421 +8
+ Misses 1562 1556 -6
+ Partials 408 406 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Bumps github.com/valyala/fasthttp from 1.57.0 to 1.58.0.
Release notes
Sourced from github.com/valyala/fasthttp's releases.
Commits
f203307
fix: ShutdownWithContext and ctx.Done() exist race. (#1908)7b74fc9
fix: lenient chunk extension parsing leading to request smuggling issues (#1899)ed2d390
fix: incorrect handling of negative cookie.maxAge #1900 (#1902)bbc2b6f
chore(deps): bump golang.org/x/net from 0.30.0 to 0.31.0 (#1897)bc70d31
refactor: fix revive.indent-error-flow lint issues (#1896)f6ba4ab
perf: improve copyZeroAlloc for File and TCPConn (#1893)bea47f5
chore(deps): bump golang.org/x/crypto from 0.28.0 to 0.29.0 (#1895)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)