Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3: Improve path validation in Static Middleware #3105

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Do not prefix with /

42e4a1a
Select commit
Loading
Failed to load commit list.
Open

v3: Improve path validation in Static Middleware #3105

Do not prefix with /
42e4a1a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 10, 2024 in 1s

82.81% (-0.05%) compared to 4347857

View this Pull Request on Codecov

82.81% (-0.05%) compared to 4347857

Details

Codecov Report

Attention: Patch coverage is 46.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.81%. Comparing base (4347857) to head (42e4a1a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
middleware/static/static.go 46.66% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3105      +/-   ##
==========================================
- Coverage   82.86%   82.81%   -0.05%     
==========================================
  Files         115      115              
  Lines       11295    11309      +14     
==========================================
+ Hits         9360     9366       +6     
- Misses       1537     1543       +6     
- Partials      398      400       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.