Improve initializations order, especially with regards to type registration, physics, and navigation. #106875
+166
−128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivorforce
force-pushed
the
object-type-register-order-first-fix
branch
from
8c75ba8 to
8199c68
Compare
dalexeev
reviewed
May 27, 2025
| @@ -139,6 +139,7 @@ static void _editor_init() { | |||
| void initialize_gdscript_module(ModuleInitializationLevel p_level) { | |||
| if (p_level == MODULE_INITIALIZATION_LEVEL_SERVERS) { | |||
| GDREGISTER_CLASS(GDScript); | |||
| GDREGISTER_ABSTRACT_CLASS(GDScriptNativeClass); | |||
There was a problem hiding this comment.
As far as I know, GDScriptNativeClass is not supposed to be exposed.
There was a problem hiding this comment.
It's using _bind_methods though to bind new.
Perhaps it is supposed to be registered as internal?
Or i can stay agnostic and remove this change for now :)
There was a problem hiding this comment.
This is more of a hack due to the lack of first-class types. GDScriptNativeType instances are obtainable, you can use them like Node.new() and is_instance_of(object, Node), but they were never meant to be exposed.
Ivorforce
force-pushed
the
object-type-register-order-first-fix
branch
from
8199c68 to
a7b144b
Compare
…egistration, physics, and navigation.
Ivorforce
force-pushed
the
object-type-register-order-first-fix
branch
from
a7b144b to
75e6d44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've used the warnings introduced in #106873 to sanitize initialization order a bit, reducing the number of warnings by a few tens.
This may fix some subtle bugs, but may also introduce regressions if I've changed anything incorrectly. Hopefully though, it should be better overall than before.
This should be the hardest part of fixing the warnings introduced by #106873. Most of the rest should be switching to
GDSOFTCLASS, or addingGDREGISTER_CLASScalls in the appropriate spots.Tagging @smix8 and @mihe for navigation and physics changes, respectively.
Changes
register_core_typesregisters important types first (Object,RefCounted, etc.)register_server_typesis called before creating server singletons.register_scene_typesis called before creating scene singletons.GDScripteditor types are registered and handled duringEDITORinitialization instead ofSERVERS, as this is where it's expected.SCENEinstead ofCORE, as this is where it's expected.GDSOFTCLASSas they're not meant to be exposed. This should be followed up with similar changes for other platforms.register_scene_typesandregister_server_typesare rearranged for expected order.