Skip to content

Conversation

@syntaxerror247
Copy link
Member

@syntaxerror247 syntaxerror247 commented May 27, 2025

This PR adds support for OS.get_version_alias() on Android. It returns android release string and sdk_version+incremental, for eg. 15 (SDK 35 build abc528-11988f) on my Android 15 device.

@syntaxerror247
Copy link
Member Author

syntaxerror247 commented May 27, 2025

Should this method also return android version codename?
CC @Alex2782 @m4gr3d

@Alex2782
Copy link
Member

Alex2782 commented May 27, 2025

My suggestion for get_version_alias would be to attach everything that is important for debugging (Copy System Info), including custom ROMs (props) --> src get_version

Example:

  • Android 14 (SDK 34) (as shown in the Play Console)
  • "+" - {more Informations: Custom ROM, etc.} (if available and relevant for issue reports)
  • ... and what kind of information is useful for XR devices?

Copy System Info on MacOS (for comparison, get_version_alias is used)

Godot v4.4.1.stable - macOS Sequoia (15.5.0) - Multi-window, 1 monitor - OpenGL 3 (Compatibility) - Apple M1 - Apple M1 (8 threads)


The documentation would then have to be adapted accordingly:

https://docs.godotengine.org/en/4.4/classes/class_os.html#class-os-method-get-version-alias

Note: This method is only supported on Windows and macOS. On other operating systems, it returns the same value as get_version().

@akien-mga akien-mga modified the milestones: 4.x, 4.5 May 28, 2025
@syntaxerror247 syntaxerror247 requested a review from a team as a code owner May 30, 2025 12:40
@Calinou
Copy link
Member

Calinou commented May 30, 2025

Should this method also return android version codename?

Android versions since 10 don't have "marketing" codenames anymore, so I wouldn't add them. Internal codenames do exist (check Wikipedia), but they aren't used in branding material.

@Repiteo Repiteo merged commit 9ee7d78 into godotengine:master Jun 2, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jun 3, 2025

Thanks!

@syntaxerror247 syntaxerror247 deleted the alias branch June 12, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants