Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @karroffel mentioned that a new cargo version is coming soon, I think it might be a good time to move this out of draft status, so the feature might get into the release!
Implements optional arguments in both
godot_wrap_method
and themethods
procedural macro. Closes #185.Explanation
This patch allows declaring optional arguments with the following syntax:
With
godot_wrap_method
:With the procedural macro:
Default values for optional arguments are obtained with
Default
. The behavior regardingOption<T>
is consistent with itsFromVariant
implementation, so it should be easy to convert an existing function into one with optional arguments.Future possibilities
VarArgs methods
With attribute argument parsing in place, it should be easy to later extend the syntax to allow VarArgs methods. Sample: