web: drop packages/ and composite from tsc -p . graph#22102
Open
GirlBossRush wants to merge 1 commit intogoauthentik:mainfrom
Open
web: drop packages/ and composite from tsc -p . graph#22102GirlBossRush wants to merge 1 commit intogoauthentik:mainfrom
packages/ and composite from tsc -p . graph#22102GirlBossRush wants to merge 1 commit intogoauthentik:mainfrom
Conversation
…k#22100) Excluding the workspace subpackages cuts the program graph from 2719 to 1800 non-`node_modules` files (-34%) — most of the drop is the 912 generated files in `packages/client-ts/src/`, which are pulled in by the recursive include glob even though that package has its own composite tsconfig and is consumed via `@goauthentik/api/dist/*.d.ts`. The base `@goauthentik/tsconfig` sets `composite: true`, which forced TS6307 the moment we tried to exclude `packages/` (`@goauthentik/core` imports get followed into `web/packages/core/`). Nothing references `web` in this repo, so disabling composite is safe; `incremental` is inherited from the base and still drives the `.tsbuildinfo` cache. On this branch: - cold `tsc -p .` 26.3s → 22.7s (-14%) - warm `tsc -p .` 4.1s → 3.5s (-15%) - `npm run precommit` 39.9s → 37.9s warm Type coverage is unchanged: each excluded package already type-checks itself via its own tsconfig + build, and stories/tests/e2e remain in the include set. Co-Authored-By: Agent (authentik-i22100-affordable-constant-chartreuse) <279763771+playpen-agent@users.noreply.github.com>
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22102 +/- ##
==========================================
+ Coverage 93.15% 93.19% +0.03%
==========================================
Files 1024 1026 +2
Lines 59278 59410 +132
Branches 400 400
==========================================
+ Hits 55223 55365 +142
+ Misses 4055 4045 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22100.
Change
web/tsconfig.json:packages/from thetsc -p .include graph.composite: false(the base@goauthentik/tsconfigenables it).Why
tsc -p .was pulling 2719 non-node_modulesfiles into the program; 912 of those were generated files inpackages/client-ts/src/. Each workspace subpackage already type-checks itself via its own composite tsconfig and is consumed bywebthrough compiled.d.tsoutputs (e.g.@goauthentik/api/dist/*.d.ts), so they don't need to be re-checked from the top-level program.Excluding
packages/triggered TS6307 because the base config setscomposite: true, and@goauthentik/coreimports get followed back intoweb/packages/core/. Nothing in the repo referenceswebas a project, so disablingcompositefor this leaf is safe.incrementalis still inherited from the base, so the.tsbuildinfocache continues to drive warm runs.Measurements (this branch)
tsc -p .coldtsc -p .warmnpm run precommitwarmCoverage
Unchanged. Each excluded subpackage type-checks itself; stories, tests, and e2e remain in the include set.