Skip to content

stages/identification: add configurable passwordless button label#22043

Open
dahux-net wants to merge 10 commits into
goauthentik:mainfrom
dahux-net:passwordless-button-label
Open

stages/identification: add configurable passwordless button label#22043
dahux-net wants to merge 10 commits into
goauthentik:mainfrom
dahux-net:passwordless-button-label

Conversation

@dahux-net
Copy link
Copy Markdown

Problem

passwordless_flow is a generic mechanism — admins point it at any
authentication flow. But the button text is hardcoded to "Use a
security key", which does not match non-WebAuthn flows.

Organizations already use passwordless_flow for email-based
authentication, but the misleading label forces them to either fork
or accept confusing UX.

Fixes #22042

Solution

Add an optional passwordless_label TextField to IdentificationStage.
When blank → existing behavior. When set → renders custom text.

Changes

  • Model: passwordless_label TextField (blank=True, default="")
  • API: passwordlessLabel in IdentificationChallenge, conditional in view
  • Frontend: fallback to msg("Use a security key") when label is empty
  • Admin: text input next to passwordlessFlow selector
  • Migration: 0018_identificationstage_passwordless_label
  • Tests: label inclusion, label omission, passwordless flow integration

Rationale

  • One field, no new models, no new stages, no new APIs
  • Follows the same pattern as passwordless_flow URL itself
  • Zero behavior change for existing deployments
  • Enables any passwordless method without custom code

David Segonds added 2 commits May 4, 2026 23:34
Add optional `passwordless_label` field to IdentificationStage that
overrides the hardcoded "Use a security key" button text. When blank,
existing behavior is preserved.

- Model: `passwordless_label` TextField (blank=True, default="")
- API: `passwordlessLabel` in IdentificationChallenge, conditional in view
- Frontend: fallback to `msg("Use a security key")` when label is empty
- Admin: text input next to passwordlessFlow selector
- Migration: 0018_identificationstage_passwordless_label
- Tests: label inclusion, label omission, passwordless flow integration
@dahux-net dahux-net requested review from a team as code owners May 4, 2026 22:11
@netlify
Copy link
Copy Markdown

netlify Bot commented May 4, 2026

Deploy Preview for authentik-integrations ready!

Name Link
🔨 Latest commit 60d121d
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/6a02fef5b06b8c00086d515f
😎 Deploy Preview https://deploy-preview-22043--authentik-integrations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 4, 2026

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 60d121d
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/6a02fef53b890f0008d9df55
😎 Deploy Preview https://deploy-preview-22043--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 4, 2026

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 60d121d
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/6a02fef5c172cf00087d8123
😎 Deploy Preview https://deploy-preview-22043--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.12%. Comparing base (828a380) to head (2d1613a).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22043      +/-   ##
==========================================
- Coverage   93.17%   93.12%   -0.06%     
==========================================
  Files        1024     1024              
  Lines       59278    59308      +30     
  Branches      400      400              
==========================================
- Hits        55234    55229       -5     
- Misses       4044     4079      +35     
Flag Coverage Δ
conformance 36.89% <6.66%> (-0.02%) ⬇️
e2e 42.07% <6.66%> (-0.02%) ⬇️
integration 32.78% <6.66%> (-0.52%) ⬇️
rust 0.00% <ø> (ø)
unit 92.10% <100.00%> (+<0.01%) ⬆️
unit-migrate 92.11% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

stages/identification: passwordless flow button label is hardcoded to "Use a security key"

1 participant