Skip to content

add new API GetEphemerals #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add new API GetEphemerals #45

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d8d81fc
add GetEphemerals for zk 3.6
kaixinbaba Jan 13, 2021
04173bc
fix comment
kaixinbaba Jan 13, 2021
fcf9e38
remove test
kaixinbaba Jan 13, 2021
50a2f1b
place the method and modified commentary
kaixinbaba Jan 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 0 additions & 29 deletions conn_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,33 +79,4 @@ func TestDeadlockInClose(t *testing.T) {
case <-time.After(3 * time.Second):
t.Fatal("apparent deadlock!")
}
Copy link

@nemith nemith Jan 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove the test?

Copy link
Author

@kaixinbaba kaixinbaba Jan 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At that time, I wrote a unit test for GetEphemerals, which uses the ZK service of direct connection 127.0.0.1. This requires me to start a ZK service locally. However, after the first two commits were submitted, GitHub's default unit test check failed directly. So I tried to remove this unit test and verify whether the automatic check would pass. Obviously, another problem I mentioned above appeared One question (How to fix the 'Codecov Report'?) Maybe I should comment on the test? Because it seems that there is no corresponding test method for other public methods

}

func TestGetEphemerals(t *testing.T) {
conn, _, err := Connect([]string{"127.0.0.1"}, time.Second) //*10)
if err != nil {
panic(err)
}
defer conn.Close()
conn.Create("/zktest", []byte("placeholder"), 0, WorldACL(PermAll))
conn.Create("/zktest/testblabla", []byte("placeholder"), FlagEphemeral, WorldACL(PermAll))
conn.Create("/zktest/nonono", []byte("placeholder"), FlagEphemeral, WorldACL(PermAll))
conn.Create("/testE", []byte("placeholder"), FlagEphemeral, WorldACL(PermAll))
conn.Create("/testE2", []byte("placeholder"), FlagEphemeral, WorldACL(PermAll))

e1, _ := conn.GetEphemerals("/zktest")
if len(e1) != 2 {
t.Fatalf("/zktest result should be 2, but got %d", len(e1))
}

e2, _ := conn.GetEphemerals("/")
if len(e2) != 4 {
t.Fatalf("/zktest result should be 4, but got %d", len(e2))
}

e3, _ := conn.GetEphemerals("/testE")
if len(e3) != 2 {
t.Fatalf("/zktest result should be 2, but got %d", len(e3))
}

}