feat: bumps the version of the common subchart to 4.1.2
#10
Conversation
| NAMESPACE=$(RELEASE_NAME) | ||
| OUTPUT_DIR=output | ||
|
|
||
| template: values.yaml |
There was a problem hiding this comment.
Would we need to run that in ci during release?
There was a problem hiding this comment.
Nope, this is for dev purpose, I was using that a lot during development.
I'm not THAT familiar with writing Helm charts, but it seems that the common team have some pattern for unit testing the charts, might look into that later.
There was a problem hiding this comment.
You might not need to bother with Typesense since we're currently exploring if we'll get rid of it completely (we'll need an alternative to move forward with that).
There was a problem hiding this comment.
Right, I'm targeting 0.24.6 for now. Trying to establish parity between the charts as a baseline.
For 3.x release of the chart I would target getting rid of the commons. It seems good as a starting point, but in a longer term it feels like I'm trying to understand how to work with the library instead of how to deploy the chart.
| {{- if .Values.redis.enabled }} | ||
| VIKUNJA_REDIS_ENABLED: true | ||
| {{- end }} | ||
| {{- if .Values.redis.enabled }} |
There was a problem hiding this comment.
This should probably be something else?
There was a problem hiding this comment.
yes :)
that's why it's still in a draft, it's generating mostly similar resources but there are still some things missing (e.g. typesense). it seems to me that the naming patterns changed too.
2 participants
Before introducing other changes, this PR updates the subchart
commonto the current version.BREAKING CHANGE:
common1.5.1 -> 4.1.2, which had introduced some breaking changes between the chart's values.fixes #6