Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(skip): use new skip logic for stages #625

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+39 −28
Draft

refactor(skip): use new skip logic for stages #625

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71cd5eb
refactor(skip): use new skip logic for stages
Feb 21, 2025
794e378
Merge branch 'main' into refactor/stage-status-skip-logic
ecrupper Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'main' into refactor/stage-status-skip-logic
@ecrupper
ecrupper committed Mar 14, 2025
commit 794e378268d7af5f271b9ea23e95604b293ecdbd
14 changes: 7 additions & 7 deletions go.mod
View file
Original file line number Diff line number Diff line change
@@ -155,13 +155,13 @@ require (
github.com/ugorji/go/codec v1.2.12 // indirect
github.com/xrash/smetrics v0.0.0-20240521201337-686a1a2994c1 // indirect
github.com/yuin/gopher-lua v1.1.1 // indirect
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.59.0 // indirect
go.opentelemetry.io/otel v1.34.0 // indirect
go.opentelemetry.io/otel/metric v1.34.0 // indirect
go.opentelemetry.io/otel/trace v1.34.0 // indirect
go.starlark.net v0.0.0-20250128212104-d908c3ead437 // indirect
golang.org/x/arch v0.13.0 // indirect
golang.org/x/crypto v0.32.0 // indirect
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.60.0 // indirect
go.opentelemetry.io/otel v1.35.0 // indirect
go.opentelemetry.io/otel/metric v1.35.0 // indirect
go.opentelemetry.io/otel/trace v1.35.0 // indirect
go.starlark.net v0.0.0-20250225190231-0d3f41d403af // indirect
golang.org/x/arch v0.14.0 // indirect
golang.org/x/crypto v0.36.0 // indirect
golang.org/x/mod v0.21.0 // indirect
golang.org/x/net v0.35.0 // indirect
golang.org/x/oauth2 v0.28.0 // indirect
18 changes: 10 additions & 8 deletions go.sum
View file
Original file line number Diff line number Diff line change
@@ -119,10 +119,10 @@ github.com/go-playground/validator/v10 v10.25.0 h1:5Dh7cjvzR7BRZadnsVOzPhWsrwUr0
github.com/go-playground/validator/v10 v10.25.0/go.mod h1:GGzBIJMuE98Ic/kJsBXbz1x/7cByt++cQ+YOuDM5wus=
github.com/go-task/slim-sprig/v3 v3.0.0 h1:sUs3vkvUymDpBKi3qH1YSqBQk9+9D/8M2mN1vB6EwHI=
github.com/go-task/slim-sprig/v3 v3.0.0/go.mod h1:W848ghGpv3Qj3dhTPRyJypKRiqCdHZiAzKg9hl15HA8=
github.com/go-vela/sdk-go v0.26.0 h1:j5Q2LzHFt7BV34Eub4a1b3Nz1VVUVqSxgIAVhHgVtTU=
github.com/go-vela/sdk-go v0.26.0/go.mod h1:+KoGEZNkqxsPOjgi7mEGdsBVA4Jj+vp1xr8oDJsaIGk=
github.com/goccy/go-json v0.10.4 h1:JSwxQzIqKfmFX1swYPpUThQZp/Ka4wzJdK0LWVytLPM=
github.com/goccy/go-json v0.10.4/go.mod h1:oq7eo15ShAhp70Anwd5lgX2pLfOS3QCiwU/PULtXL6M=
github.com/go-vela/sdk-go v0.26.2 h1:uqYZNO9VYfDiyXl7MMgUt6XwBwvIj3OWWAIa8q9RuXE=
github.com/go-vela/sdk-go v0.26.2/go.mod h1:XLnki5qdk8R+y+J65AOuiJ1pQyBmy7P46E85SPOv0Ww=
github.com/goccy/go-json v0.10.5 h1:Fq85nIqj+gXn/S5ahsiTlK3TmC85qgirsdTP/+DeaC4=
github.com/goccy/go-json v0.10.5/go.mod h1:oq7eo15ShAhp70Anwd5lgX2pLfOS3QCiwU/PULtXL6M=
github.com/gogo/protobuf v1.3.2 h1:Ov1cvc58UF3b5XjBnZv7+opcTcQFZebYjWzi34vdm4Q=
github.com/gogo/protobuf v1.3.2/go.mod h1:P1XiOD3dCwIKUDQYPy72D8LYyHL2YPYrpS2s69NZV8Q=
github.com/golang-jwt/jwt/v5 v5.2.1 h1:OuVbFODueb089Lh128TAcimifWaLhJwVflnrgM17wHk=
@@ -348,10 +348,12 @@ go.opentelemetry.io/otel/trace v1.35.0 h1:dPpEfJu1sDIqruz7BHFG3c7528f6ddfSWfFDVt
go.opentelemetry.io/otel/trace v1.35.0/go.mod h1:WUk7DtFp1Aw2MkvqGdwiXYDZZNvA/1J8o6xRXLrIkyc=
go.opentelemetry.io/proto/otlp v1.5.0 h1:xJvq7gMzB31/d406fB8U5CBdyQGw4P399D1aQWU/3i4=
go.opentelemetry.io/proto/otlp v1.5.0/go.mod h1:keN8WnHxOy8PG0rQZjJJ5A2ebUoafqWp0eVQ4yIXvJ4=
go.starlark.net v0.0.0-20250128212104-d908c3ead437 h1:S+5NdaGkB7iQUrL3EFN5/yRs1YjGuRs8MRcafiRdhro=
go.starlark.net v0.0.0-20250128212104-d908c3ead437/go.mod h1:YKMCv9b1WrfWmeqdV5MAuEHWsu5iC+fe6kYl2sQjdI8=
golang.org/x/arch v0.13.0 h1:KCkqVVV1kGg0X87TFysjCJ8MxtZEIU4Ja/yXGeoECdA=
golang.org/x/arch v0.13.0/go.mod h1:FEVrYAQjsQXMVJ1nsMoVVXPZg6p2JE2mx8psSWTDQys=
go.starlark.net v0.0.0-20250225190231-0d3f41d403af h1:gdHSl5pZSdC+7qdBKx0n0x4Y2b4UNjuKnKH8Lfwft3o=
go.starlark.net v0.0.0-20250225190231-0d3f41d403af/go.mod h1:YKMCv9b1WrfWmeqdV5MAuEHWsu5iC+fe6kYl2sQjdI8=
go.uber.org/goleak v1.3.0 h1:2K3zAYmnTNqV73imy9J1T3WC+gmCePx2hEGkimedGto=
go.uber.org/goleak v1.3.0/go.mod h1:CoHD4mav9JJNrW/WLlf7HGZPjdw8EucARQHekz1X6bE=
golang.org/x/arch v0.14.0 h1:z9JUEZWr8x4rR0OU6c4/4t6E6jOZ8/QBS2bBYBm4tx4=
golang.org/x/arch v0.14.0/go.mod h1:FEVrYAQjsQXMVJ1nsMoVVXPZg6p2JE2mx8psSWTDQys=
golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI=
golang.org/x/crypto v0.0.0-20200622213623-75b288015ac9/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto=

Unchanged files with check annotations Beta

View file
cmd/vela-worker/exec.go
"github.com/go-vela/sdk-go/vela"
api "github.com/go-vela/server/api/types"
"github.com/go-vela/server/compiler/types/pipeline"

Check failure on line 17 in cmd/vela-worker/exec.go

GitHub Actions / build 

github.com/go-vela/server@v0.26.3: replacement directory ../server does not exist

Check failure on line 17 in cmd/vela-worker/exec.go

GitHub Actions / build 

github.com/go-vela/server@v0.26.3: replacement directory ../server does not exist
"github.com/go-vela/server/constants"
"github.com/go-vela/server/queue/models"

Check failure on line 19 in cmd/vela-worker/exec.go

GitHub Actions / build 

github.com/go-vela/server@v0.26.3: replacement directory ../server does not exist

Check failure on line 19 in cmd/vela-worker/exec.go

GitHub Actions / test 

github.com/go-vela/server@v0.26.3: replacement directory ../server does not exist

Check failure on line 19 in cmd/vela-worker/exec.go

GitHub Actions / test 

github.com/go-vela/server@v0.26.3: replacement directory ../server does not exist

Check failure on line 19 in cmd/vela-worker/exec.go

GitHub Actions / build 

github.com/go-vela/server@v0.26.3: replacement directory ../server does not exist
"github.com/go-vela/worker/executor"
"github.com/go-vela/worker/runtime"
"github.com/go-vela/worker/version"
View file
cmd/vela-worker/flags.go
"github.com/urfave/cli/v2"
"github.com/go-vela/server/queue"

Check failure on line 10 in cmd/vela-worker/flags.go

GitHub Actions / build 

github.com/go-vela/server@v0.26.3: replacement directory ../server does not exist

Check failure on line 10 in cmd/vela-worker/flags.go

GitHub Actions / test 

github.com/go-vela/server@v0.26.3: replacement directory ../server does not exist

Check failure on line 10 in cmd/vela-worker/flags.go

GitHub Actions / test 

github.com/go-vela/server@v0.26.3: replacement directory ../server does not exist

Check failure on line 10 in cmd/vela-worker/flags.go

GitHub Actions / build 

github.com/go-vela/server@v0.26.3: replacement directory ../server does not exist
"github.com/go-vela/worker/executor"
"github.com/go-vela/worker/runtime"
)
View file
version/version.go
"github.com/Masterminds/semver/v3"
"github.com/sirupsen/logrus"
"github.com/go-vela/server/version"

Check failure on line 12 in version/version.go

GitHub Actions / build 

github.com/go-vela/server@v0.26.3: replacement directory ../server does not exist

Check failure on line 12 in version/version.go

GitHub Actions / test 

github.com/go-vela/server@v0.26.3: replacement directory ../server does not exist

Check failure on line 12 in version/version.go

GitHub Actions / test 

github.com/go-vela/server@v0.26.3: replacement directory ../server does not exist

Check failure on line 12 in version/version.go

GitHub Actions / build 

github.com/go-vela/server@v0.26.3: replacement directory ../server does not exist
)
var (
View file
api/build.go
"github.com/gin-gonic/gin"
api "github.com/go-vela/server/api/types"

Check failure on line 11 in api/build.go

GitHub Actions / test 

github.com/go-vela/server@v0.26.3: replacement directory ../server does not exist

Check failure on line 11 in api/build.go

GitHub Actions / test 

github.com/go-vela/server@v0.26.3: replacement directory ../server does not exist
"github.com/go-vela/worker/router/middleware/executor"
)
View file
executor/engine.go
"sync"
api "github.com/go-vela/server/api/types"
"github.com/go-vela/server/compiler/types/pipeline"

Check failure on line 10 in executor/engine.go

GitHub Actions / test 

github.com/go-vela/server@v0.26.3: replacement directory ../server does not exist

Check failure on line 10 in executor/engine.go

GitHub Actions / test 

github.com/go-vela/server@v0.26.3: replacement directory ../server does not exist
)
// Engine represents the interface for Vela integrating
View file
executor/executor_test.go
Version: "1",
ID: "github_octocat_1",
Steps: pipeline.ContainerSlice{
{

Check failure on line 196 in executor/executor_test.go

GitHub Actions / golangci

[golangci] executor/executor_test.go#L196 

missing type in composite literal (typecheck)
Raw output 
executor/executor_test.go:196:4: missing type in composite literal (typecheck)
			{
			^

Check failure on line 196 in executor/executor_test.go

GitHub Actions / diff-review 

missing type in composite literal (typecheck)

Check failure on line 196 in executor/executor_test.go

GitHub Actions / full-review 

missing type in composite literal (typecheck)

Check failure on line 196 in executor/executor_test.go

GitHub Actions / full-review 

missing type in composite literal (typecheck)
ID: "step_github_octocat_1_init",
Directory: "/home/github/octocat",
Image: "#init",
Number: 1,
Pull: "always",
},
{

Check failure on line 204 in executor/executor_test.go

GitHub Actions / golangci

[golangci] executor/executor_test.go#L204 

missing type in composite literal (typecheck)
Raw output 
executor/executor_test.go:204:4: missing type in composite literal (typecheck)
			{
			^

Check failure on line 204 in executor/executor_test.go

GitHub Actions / diff-review 

missing type in composite literal (typecheck)

Check failure on line 204 in executor/executor_test.go

GitHub Actions / full-review 

missing type in composite literal (typecheck)

Check failure on line 204 in executor/executor_test.go

GitHub Actions / full-review 

missing type in composite literal (typecheck)
ID: "step_github_octocat_1_clone",
Directory: "/home/github/octocat",
Image: "target/vela-git:v0.3.0",
Number: 2,
Pull: "always",
},
{

Check failure on line 212 in executor/executor_test.go

GitHub Actions / golangci

[golangci] executor/executor_test.go#L212 

missing type in composite literal (typecheck)
Raw output 
executor/executor_test.go:212:4: missing type in composite literal (typecheck)
			{
			^

Check failure on line 212 in executor/executor_test.go

GitHub Actions / diff-review 

missing type in composite literal (typecheck)

Check failure on line 212 in executor/executor_test.go

GitHub Actions / full-review 

missing type in composite literal (typecheck)

Check failure on line 212 in executor/executor_test.go

GitHub Actions / full-review 

missing type in composite literal (typecheck)
ID: "step_github_octocat_1_echo",
Commands: []string{"echo hello"},
Directory: "/home/github/octocat",
You are viewing a condensed version of this merge commit. You can view the full changes here.