enhance(init): display basic worker info in init step logs#510
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #510 +/- ##
==========================================
+ Coverage 83.42% 83.44% +0.01%
==========================================
Files 69 69
Lines 5376 5381 +5
==========================================
+ Hits 4485 4490 +5
Misses 746 746
Partials 145 145
|
wass3rw3rk
approved these changes
Sep 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes go-vela/community#125.
While we can leverage the hover display on the build nav bar to check the worker that ran a specific build, I've found this to be a bit finicky and more difficult to analyze older builds. Throwing some basic worker / runtime info in the init step seems like a fairly simple win.
I can also foresee this change being temporary if/when the init step overhaul proposal gets off the ground and running.