feat(server): test report storage addition #1271

timhuynh94 · 2025-03-12T19:41:10Z

No description provided.

* refactor(pipeline): use server API types for pipeline and migrate compiler types * gci * feat: add sender rule for pipelines --------- Co-authored-by: David May <[email protected]>

* chore(lint): address existing linter issues * remove dupl from exclusion list

* enhance(build): add fork field for OIDC * fix test * integration test update

* enhance(yaml): allow for users to parse pipelines using old library * testing file for internal yaml * chore(compiler): convert unmarshaled buildkite to go-yaml * remove tests used in later PRs * lintfix * fix schema * gci

…1230) Co-authored-by: David May <[email protected]>

Co-authored-by: david may <[email protected]>

* init commit * feat(repo): add pending approval timeout * fix test * remove dead code --------- Co-authored-by: David May <[email protected]>

…r have dupl anchors in map (#1232)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

storage/minio/download.go

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

golangci

🚫 [golangci] _{reported by reviewdog 🐶}
expressions should not be cuddled with blocks (wsl)

server/api/admin/storage.go

Line 65 in 638c15a

l.Debugf("bucket name: %s", input.BucketName)

🚫 [golangci] _{reported by reviewdog 🐶}
if statements should only be cuddled with assignments (wsl)

server/api/storage/storage.go

Line 121 in 638c15a

if input.Bucket.BucketName == "" || input.ObjectName == "" {

🚫 [golangci] _{reported by reviewdog 🐶}
assignments should only be cuddled with other assignments (wsl)

server/api/storage/storage.go

Line 131 in 638c15a

err = storage.FromGinContext(c).Upload(ctx, input)

🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before if statement (wsl)

server/api/storage/storage.go

Line 132 in 638c15a

if err != nil {

🚫 [golangci] _{reported by reviewdog 🐶}
expressions should not be cuddled with blocks (wsl)

server/storage/storage.go

Line 40 in 638c15a

logrus.Debug("creating storage client from setup")

🚫 [golangci] _{reported by reviewdog 🐶}
declarations should never be cuddled (wsl)

server/storage/minio/create_bucket.go

Line 13 in 638c15a

var opts minio.MakeBucketOptions

🚫 [golangci] _{reported by reviewdog 🐶}
assignments should only be cuddled with other assignments (wsl)

server/storage/minio/create_bucket.go

Line 16 in 638c15a

opts = minio.MakeBucketOptions{}

🚫 [golangci] _{reported by reviewdog 🐶}
ranges should only be cuddled with assignments used in the iteration (wsl)

server/storage/minio/list_objects.go

Line 15 in 638c15a

for object := range objectCh {

🚫 [golangci] _{reported by reviewdog 🐶}
append only allowed to cuddle with appended value (wsl)

server/storage/minio/list_objects.go

Line 19 in 638c15a

objects = append(objects, object.Key)

🚫 [golangci] _{reported by reviewdog 🐶}
block should not end with a whitespace (or comment) (wsl)

server/storage/minio/minio.go

Line 88 in 638c15a

}

🚫 [golangci] _{reported by reviewdog 🐶}
expressions should not be cuddled with blocks (wsl)

server/storage/minio/upload.go

Line 34 in 638c15a

c.Logger.Infof("uploaded object %v with size %d", info, info.Size)

codecov · 2025-03-13T20:32:00Z

Codecov Report

Attention: Patch coverage is 40.48387% with 369 lines in your changes missing coverage. Please review.

Project coverage is 56.27%. Comparing base (6ddedeb) to head (4055774).

Files with missing lines	Patch %	Lines
api/admin/storage.go	0.00%	99 Missing ⚠️
storage/minio/download.go	0.00%	48 Missing ⚠️
api/storage/storage.go	0.00%	25 Missing ⚠️
storage/minio/presigned_get_object.go	0.00%	19 Missing ⚠️
cmd/vela-server/metadata.go	0.00%	17 Missing ⚠️
mock/server/worker.go	0.00%	16 Missing ⚠️
storage/minio/upload.go	23.80%	16 Missing ⚠️
storage/minio/create_bucket.go	44.44%	12 Missing and 3 partials ⚠️
storage/minio/list_objects.go	0.00%	13 Missing ⚠️
storage/storage.go	58.06%	13 Missing ⚠️
... and 15 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1271      +/-   ##
==========================================
- Coverage   56.55%   56.27%   -0.28%     
==========================================
  Files         630      650      +20     
  Lines       35709    36329     +620     
==========================================
+ Hits        20194    20445     +251     
- Misses      14828    15188     +360     
- Partials      687      696       +9

Files with missing lines	Coverage Δ
compiler/types/yaml/yaml/secret.go	`87.74% <ø> (ø)`
router/build.go	`0.00% <ø> (ø)`
router/middleware/signing.go	`100.00% <100.00%> (ø)`
router/middleware/storage.go	`100.00% <100.00%> (ø)`
storage/setup.go	`100.00% <100.00%> (ø)`
api/types/storage_info.go	`97.91% <97.91%> (ø)`
api/types/storage.go	`0.00% <0.00%> (ø)`
cmd/vela-server/main.go	`0.00% <0.00%> (ø)`
mock/server/server.go	`0.00% <0.00%> (ø)`
router/router.go	`0.00% <0.00%> (ø)`
... and 20 more

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

… in path expression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

golangci

🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before if statement (wsl)

server/api/storage/storage.go

Line 132 in e6ce703

if err != nil {

🚫 [golangci] _{reported by reviewdog 🐶}
expressions should not be cuddled with blocks (wsl)

server/storage/storage.go

Line 40 in e6ce703

logrus.Debug("creating storage client from setup")

🚫 [golangci] _{reported by reviewdog 🐶}
declarations should never be cuddled (wsl)

server/storage/minio/create_bucket.go

Line 13 in e6ce703

var opts minio.MakeBucketOptions

🚫 [golangci] _{reported by reviewdog 🐶}
assignments should only be cuddled with other assignments (wsl)

server/storage/minio/create_bucket.go

Line 16 in e6ce703

opts = minio.MakeBucketOptions{}

🚫 [golangci] _{reported by reviewdog 🐶}
block should not end with a whitespace (or comment) (wsl)

server/storage/minio/minio.go

Line 88 in e6ce703

}

🚫 [golangci] _{reported by reviewdog 🐶}
expressions should not be cuddled with blocks (wsl)

server/storage/minio/upload.go

Line 34 in e6ce703

c.Logger.Infof("uploaded object %v with size %d", info, info.Size)

🚫 [golangci] _{reported by reviewdog 🐶}
directive //nolint:revive // ignore returning unexported client is unused for linter "revive" (nolintlint)

server/storage/minio/minio.go

Line 95 in e6ce703

//nolint:revive // ignore returning unexported client

TimHuynh and others added 30 commits December 12, 2024 09:41

ground work

a2042f3

feat: add sender rule for pipelines (#1206)

8fb48dc

* refactor(pipeline): use server API types for pipeline and migrate compiler types * gci * feat: add sender rule for pipelines --------- Co-authored-by: David May <[email protected]>

chore(lint): add struct tag align rule (#1216)

a3b1bff

chore(lint): address existing linter issues (#1218)

2245376

* chore(lint): address existing linter issues * remove dupl from exclusion list

enhance(build)!: add fork field for OIDC (#1221)

5a1f403

* enhance(build): add fork field for OIDC * fix test * integration test update

enhance(compiler): cache templates per compilation (#1224)

9a5bf00

ground work

58718a1

working admin endpoints for bucket management

8e9cd8e

working admin endpoints for object operations

3239b53

all endpoints for storage

8a95775

some working test

a4f29d0

working tests

41df509

keys for test report step

86d822d

feat: deployment config for expected params and targets (#1214)

83afd15

resolve conflicts with buildkite

8b5b79f

feat: opt-in gh app integration (#1217)

9328ecd

chore(yaml): add go-yaml types package (#1225)

b16622f

* enhance(yaml): allow for users to parse pipelines using old library * testing file for internal yaml * chore(compiler): convert unmarshaled buildkite to go-yaml * remove tests used in later PRs * lintfix * fix schema * gci

resolve conflicts

3156794

rebase

57f8f9a

enhance(yaml): allow for users to set version legacy for buildkite (#…

09da5df

…1230) Co-authored-by: David May <[email protected]>

refactor(db/build): drop source index, add event index (#1228)

114ae7b

Co-authored-by: david may <[email protected]>

feat(repo)!: add pending approval timeout (#1227)

fd16b7b

* init commit * feat(repo): add pending approval timeout * fix test * remove dead code --------- Co-authored-by: David May <[email protected]>

enhance(yaml): silent fix anchor merges in YAML maps (#1231)

68547d6

fix(webhook): use correct repo variable for enqueue (#1234)

c7c1d0a

feat(pipeline)!: add warnings to pipelines that use legacy YAML lib o…

f43e2d1

…r have dupl anchors in map (#1232)

feat: status endpoints (#1235)

f1a98ac

enhance(deploy): validate on CreateDeployment (#1236)

bf2313d

enhance(metrics): include route specific queue length (#1237)

9a532cf

chore(deps): update codecov/codecov-action action to v5 (#1222)

9f13f97

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update module github.com/google/go-github/v65 to v68 (#1229)

3920eab

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

TimHuynh and others added 6 commits March 12, 2025 14:31

remove test-report types

f61dd12

remove test-report.go and build/storage.go

446c021

remove test-report step from compiler validate

06a2a52

remove test-report step from compiler yaml and buildkite

e861dc9

white line

05f7df9

Merge branch 'main' into feat_test_report_storage_addition

6a8c948

github-advanced-security bot found potential problems Mar 12, 2025

View reviewed changes

storage/minio/download.go Fixed Show fixed Hide fixed

mod tidy

638c15a

github-actions bot reviewed Mar 12, 2025

View reviewed changes

TimHuynh added 2 commits March 13, 2025 14:56

fixing upload test

d87c9d2

fix setup test

0825d49

TimHuynh and others added 5 commits March 17, 2025 13:46

clean up some endpoints

6a7de50

Merge branch 'main' into feat_test_report_storage_addition

c6adfae

rename to client

5d12205

Potential fix for code scanning alert no. 472: Uncontrolled data used…

6b41dc0

… in path expression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

make clean

e6ce703

github-actions bot reviewed Mar 17, 2025

View reviewed changes

TimHuynh and others added 12 commits March 17, 2025 14:48

gci fix

203e6b7

clean up

7b8bec6

mod tidy

73f78a8

gci fix

6b6f9fa

typo

b2b717a

fixing swagger

8b0af38

remove unused endpoint

8a4997f

fix api spec

4055774

add test for minio

d8c3c41

updated test

fdcc0b2

Merge branch 'main' into feat_test_report_storage_addition

135783e

fix gci and spec

889d1ff

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(server): test report storage addition #1271

feat(server): test report storage addition #1271

timhuynh94 commented Mar 12, 2025

github-actions bot left a comment

codecov bot commented Mar 13, 2025 •

edited

Loading

github-actions bot left a comment

feat(server): test report storage addition #1271

Are you sure you want to change the base?

feat(server): test report storage addition #1271

Conversation

timhuynh94 commented Mar 12, 2025

github-actions bot left a comment

Choose a reason for hiding this comment

codecov bot commented Mar 13, 2025 • edited Loading

Codecov Report

github-actions bot left a comment

Choose a reason for hiding this comment

codecov bot commented Mar 13, 2025 •

edited

Loading