Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): split validate into YAML and Pipeline #1268

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Mar 11, 2025

There are a couple things that are checked during Validate that may not accurately reflect the build that ends up being run. For instance, you could name steps the same if it's guaranteed they will never run at the same time due to rulesets. By splitting validate into a YAML validation and a pipeline validation, we have a more accurate validator.

I am also moving InitStep and CloneStep to after the validation call. This is inconsequential ordering since those two functions force their respective steps to the front of the line regardless of when they are invoked.

@ecrupper ecrupper requested a review from a team as a code owner March 11, 2025 13:11
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.60%. Comparing base (3da62c5) to head (b94cd17).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1268      +/-   ##
==========================================
+ Coverage   56.55%   56.60%   +0.05%     
==========================================
  Files         630      630              
  Lines       35710    35745      +35     
==========================================
+ Hits        20195    20233      +38     
+ Misses      14828    14826       -2     
+ Partials      687      686       -1     
Files with missing lines Coverage Δ
compiler/native/compile.go 70.83% <100.00%> (+0.52%) ⬆️
compiler/native/validate.go 100.00% <100.00%> (+3.06%) ⬆️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

timhuynh94
timhuynh94 previously approved these changes Mar 12, 2025
KellyMerrick
KellyMerrick previously approved these changes Mar 12, 2025
@ecrupper ecrupper dismissed stale reviews from timhuynh94 and KellyMerrick via eb466dc March 19, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants