-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compiler): split validate into YAML and Pipeline #1268
Open
ecrupper
wants to merge
7
commits into
main
Choose a base branch
from
fix/validate-timing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1268 +/- ##
==========================================
+ Coverage 56.55% 56.60% +0.05%
==========================================
Files 630 630
Lines 35710 35745 +35
==========================================
+ Hits 20195 20233 +38
+ Misses 14828 14826 -2
+ Partials 687 686 -1
🚀 New features to boost your workflow:
|
timhuynh94
previously approved these changes
Mar 12, 2025
KellyMerrick
previously approved these changes
Mar 12, 2025
KellyMerrick
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple things that are checked during
Validate
that may not accurately reflect the build that ends up being run. For instance, you could name steps the same if it's guaranteed they will never run at the same time due to rulesets. By splitting validate into a YAML validation and a pipeline validation, we have a more accurate validator.I am also moving
InitStep
andCloneStep
to after the validation call. This is inconsequential ordering since those two functions force their respective steps to the front of the line regardless of when they are invoked.