Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database)!: adjust table types to match database/sql types #1260

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Feb 21, 2025

github.com has deployment numbers exceeding int4 size. Local stacks hooked up to public github are unable to test deployments as a result.

This also obviously spells problems for actual installations. There will be an addition to the migration script to call this out and suggest people use the BIGINT column type when dealing with sql.NullInt64 values

Also forcing the use of int32 for types that have INTEGER columns so there is no system mismatch which could cause problems.

@ecrupper ecrupper requested a review from a team as a code owner February 21, 2025 17:13
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 92.52336% with 8 lines in your changes missing coverage. Please review.

Project coverage is 56.77%. Comparing base (931af70) to head (d1cf0c5).

Files with missing lines Patch % Lines
api/repo/create.go 0.00% 4 Missing ⚠️
api/build/compile_publish.go 0.00% 1 Missing ⚠️
api/build/graph.go 0.00% 1 Missing ⚠️
api/metrics.go 0.00% 1 Missing ⚠️
api/repo/update.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1260   +/-   ##
=======================================
  Coverage   56.77%   56.77%           
=======================================
  Files         630      630           
  Lines       35476    35476           
=======================================
  Hits        20143    20143           
  Misses      14698    14698           
  Partials      635      635           
Files with missing lines Coverage Δ
api/types/build.go 97.56% <100.00%> (ø)
api/types/dashboard.go 100.00% <ø> (ø)
api/types/hook.go 100.00% <100.00%> (ø)
api/types/repo.go 99.17% <100.00%> (ø)
api/types/service.go 87.10% <100.00%> (ø)
api/types/settings/platform.go 67.53% <100.00%> (ø)
api/types/step.go 100.00% <100.00%> (ø)
api/types/worker.go 100.00% <100.00%> (ø)
compiler/native/compile.go 70.31% <ø> (ø)
compiler/template/starlark/starlark.go 43.43% <100.00%> (ø)
... and 42 more
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

KellyMerrick
KellyMerrick previously approved these changes Feb 21, 2025
timhuynh94
timhuynh94 previously approved these changes Mar 12, 2025
KellyMerrick
KellyMerrick previously approved these changes Mar 12, 2025
@wass3r
Copy link
Collaborator

wass3r commented Mar 12, 2025

We should mark this as breaking probably since it will require DB changes

@ecrupper ecrupper changed the title fix(database): adjust table types to match database/sql types fix(database)!: adjust table types to match database/sql types Mar 13, 2025
@ecrupper ecrupper dismissed stale reviews from timhuynh94 and KellyMerrick via f449760 March 20, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants