fix unnecesssary allocation in infile.go

[methane]

Description

There is a code if data == nil to avoid allocation when sending empty packet in handleInFileRequest().
But it didn't work because previous allocation happend inner block as data := make(...).
VSCode warns that if data == nil is tautology.

Checklist

• Code compiles correctly
• Created tests which fail without the change (if possible)
• All tests passing
• Extended the README / documentation, if necessary
• Added myself / the copyright holder to the AUTHORS file

[coderabbitai]

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coveralls]

coverage: 82.378% (+0.01%) from 82.368%
when pulling 16415ec on methane:fix-infile
into 87443b9 on go-sql-driver:master.

[coderabbitai]

Actionable comments posted: 1

Outside diff range and nitpick comments (1)

infile.go (1)

Line range hint 103-103: Consider simplifying the conditional logic to enhance readability.

- if idx == 0 || (idx > 0 && name[idx-1] == '/')
+ if idx >= 0 && (idx == 0 || name[idx-1] == '/')

Tools

golangci-lint

96-96: Function 'handleInFileRequest' is too long (86 > 60) (funlen)

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 87443b9 and 16415ec.

Files selected for processing (1)

• infile.go (2 hunks)

Additional context used

golangci-lint

infile.go

96-96: Function 'handleInFileRequest' is too long (86 > 60) (funlen)

---

103-103: if idx == 0 || (idx > 0 && name[idx-1] == '/') has complex nested blocks (complexity: 20) (nestif)

Additional comments not posted (2)

infile.go (2)

149-153: The changes correctly address the unnecessary allocation by moving the data array creation outside the loop and conditionally initializing it based on packetSize. Good job on optimizing this!

Also applies to: 160-160

---

Line range hint 160-160: Handling EOF as a non-error case is appropriate for file read operations.

Tools

golangci-lint

96-96: Function 'handleInFileRequest' is too long (86 > 60) (funlen)

[coderabbitai]

The function is quite lengthy and complex. Consider refactoring into smaller, more focused functions to improve maintainability and testability.

Tools

golangci-lint

96-96: Function 'handleInFileRequest' is too long (86 > 60) (funlen)

[shogo82148]

LGTM