Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update Go and MySQL versions #1557

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Conversation

methane
Copy link
Member

@methane methane commented Mar 11, 2024

Description

https://endoflife.date/mariadb

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

Summary by CodeRabbit

  • Chores
    • Updated production releases for Go and MySQL.
    • Added new and LTS versions of MariaDB.
  • Refactor
    • Changed the output writing method to use print in Python.

Copy link

coderabbitai bot commented Mar 11, 2024

Walkthrough

The latest update brings significant enhancements to the development environment, focusing on updating production releases for Go and MySQL, adding new and LTS versions of MariaDB, and refining Python code by shifting the output writing method to print. These changes aim to modernize the stack, ensure long-term support for critical components, and improve code readability and efficiency in Python scripts.

Changes

File(s) Change Summary
.github/workflows/test.yml Updated production releases for go and mysql, added new and LTS versions of mariadb, and changed the output writing method to print in Python.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 33b7747 and 740dd17.
Files selected for processing (1)
  • .github/workflows/test.yml (2 hunks)
Additional comments: 5
.github/workflows/test.yml (5)
  • 34-34: Adding Go version '1.22' ensures the CI pipeline tests against the latest production release. It's crucial to verify that the project's codebase is compatible with this version.
  • 36-36: Including Go version '1.21' in the testing matrix broadens compatibility checks with recent Go releases.
  • 41-41: Adding MySQL version '8.3' to the CI pipeline is a positive step towards ensuring compatibility with newer database versions. It's important to verify that there are no breaking changes affecting the project.
  • 43-46: Incorporating new MariaDB versions, especially LTS versions, into the CI pipeline is essential for ensuring long-term stability and compatibility. Testing against these versions helps anticipate and mitigate potential issues early.
  • 65-65: Switching to the print function for output writing in the Python script is a standard practice and enhances readability and maintainability of the script.

@coveralls
Copy link

Coverage Status

coverage: 81.989% (-0.07%) from 82.055%
when pulling 740dd17 on methane:update-ci
into 33b7747 on go-sql-driver:master.

Copy link
Contributor

@shogo82148 shogo82148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@methane methane merged commit 3147497 into go-sql-driver:master Mar 11, 2024
32 checks passed
@methane methane deleted the update-ci branch March 11, 2024 04:44
@shogo82148 shogo82148 mentioned this pull request Mar 11, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants