Skip to content

Commit

Permalink
fix outdated tests
Browse files Browse the repository at this point in the history
  • Loading branch information
ysmood committed Jul 22, 2024
1 parent e3d4a72 commit 6458984
Show file tree
Hide file tree
Showing 5 changed files with 28 additions and 25 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/setup-node@v2
- uses: actions/checkout@v4

- uses: actions/setup-node@v4
with:
node-version: 19

- uses: actions/setup-go@v4
- uses: actions/setup-go@v5
with:
go-version: 1.20.1

- uses: actions/checkout@v3
go-version: 1.21

- run: |
go get -u ./...
Expand Down
12 changes: 7 additions & 5 deletions .golangci.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
run:
skip-dirs-use-default: false

linters:
enable-all: true
disable:
Expand All @@ -22,8 +19,12 @@ linters:
- exhaustruct
- nilnil
- nonamedreturns
- mnd

# Deprecated ones:
- copyloopvar
- intrange
- execinquery
- structcheck
- interfacer
- deadcode
Expand All @@ -35,8 +36,9 @@ linters:
- nosnakecase
- scopelint

gocyclo:
min-complexity: 15
linters-settings:
gocyclo:
min-complexity: 15

issues:
exclude-use-default: false
2 changes: 1 addition & 1 deletion error-handling.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ func main() {
}

func handleError(err error) {
var evalErr *rod.ErrEval
var evalErr *rod.EvalError
if errors.Is(err, context.DeadlineExceeded) { // timeout error
fmt.Println("timeout err")
} else if errors.As(err, &evalErr) { // eval error
Expand Down
12 changes: 7 additions & 5 deletions go.mod
Original file line number Diff line number Diff line change
@@ -1,16 +1,18 @@
module github.com/go-rod/go-rod.github.io

go 1.17
go 1.21

toolchain go1.22.1

require (
github.com/go-rod/rod v0.114.2
github.com/ysmood/got v0.34.2
github.com/go-rod/rod v0.116.2
github.com/ysmood/got v0.40.0
github.com/ysmood/gson v0.7.3
)

require (
github.com/ysmood/fetchup v0.2.3 // indirect
github.com/ysmood/goob v0.4.0 // indirect
github.com/ysmood/gop v0.0.2 // indirect
github.com/ysmood/leakless v0.8.0 // indirect
github.com/ysmood/gop v0.2.0 // indirect
github.com/ysmood/leakless v0.9.0 // indirect
)
17 changes: 8 additions & 9 deletions go.sum
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
github.com/go-rod/rod v0.114.2 h1:Qwt+vZHHnb117zc0q+XjhAJCkB01hchWSxH/raCyLb4=
github.com/go-rod/rod v0.114.2/go.mod h1:aiedSEFg5DwG/fnNbUOTPMTTWX3MRj6vIs/a684Mthw=
github.com/go-rod/rod v0.116.2 h1:A5t2Ky2A+5eD/ZJQr1EfsQSe5rms5Xof/qj296e+ZqA=
github.com/go-rod/rod v0.116.2/go.mod h1:H+CMO9SCNc2TJ2WfrG+pKhITz57uGNYU43qYHh438Mg=
github.com/ysmood/fetchup v0.2.3 h1:ulX+SonA0Vma5zUFXtv52Kzip/xe7aj4vqT5AJwQ+ZQ=
github.com/ysmood/fetchup v0.2.3/go.mod h1:xhibcRKziSvol0H1/pj33dnKrYyI2ebIvz5cOOkYGns=
github.com/ysmood/goob v0.4.0 h1:HsxXhyLBeGzWXnqVKtmT9qM7EuVs/XOgkX7T6r1o1AQ=
github.com/ysmood/goob v0.4.0/go.mod h1:u6yx7ZhS4Exf2MwciFr6nIM8knHQIE22lFpWHnfql18=
github.com/ysmood/gop v0.0.2 h1:VuWweTmXK+zedLqYufJdh3PlxDNBOfFHjIZlPT2T5nw=
github.com/ysmood/gop v0.0.2/go.mod h1:rr5z2z27oGEbyB787hpEcx4ab8cCiPnKxn0SUHt6xzk=
github.com/ysmood/got v0.34.1/go.mod h1:yddyjq/PmAf08RMLSwDjPyCvHvYed+WjHnQxpH851LM=
github.com/ysmood/got v0.34.2 h1:oN4DDWwpN5BdNPqYtOIW8a13CsAdzTOECTND7pQQ148=
github.com/ysmood/got v0.34.2/go.mod h1:yddyjq/PmAf08RMLSwDjPyCvHvYed+WjHnQxpH851LM=
github.com/ysmood/gop v0.2.0 h1:+tFrG0TWPxT6p9ZaZs+VY+opCvHU8/3Fk6BaNv6kqKg=
github.com/ysmood/gop v0.2.0/go.mod h1:rr5z2z27oGEbyB787hpEcx4ab8cCiPnKxn0SUHt6xzk=
github.com/ysmood/got v0.40.0 h1:ZQk1B55zIvS7zflRrkGfPDrPG3d7+JOza1ZkNxcc74Q=
github.com/ysmood/got v0.40.0/go.mod h1:W7DdpuX6skL3NszLmAsC5hT7JAhuLZhByVzHTq874Qg=
github.com/ysmood/gotrace v0.6.0 h1:SyI1d4jclswLhg7SWTL6os3L1WOKeNn/ZtzVQF8QmdY=
github.com/ysmood/gotrace v0.6.0/go.mod h1:TzhIG7nHDry5//eYZDYcTzuJLYQIkykJzCRIo4/dzQM=
github.com/ysmood/gson v0.7.3 h1:QFkWbTH8MxyUTKPkVWAENJhxqdBa4lYTQWqZCiLG6kE=
github.com/ysmood/gson v0.7.3/go.mod h1:3Kzs5zDl21g5F/BlLTNcuAGAYLKt2lV5G8D1zF3RNmg=
github.com/ysmood/leakless v0.8.0 h1:BzLrVoiwxikpgEQR0Lk8NyBN5Cit2b1z+u0mgL4ZJak=
github.com/ysmood/leakless v0.8.0/go.mod h1:R8iAXPRaG97QJwqxs74RdwzcRHT1SWCGTNqY8q0JvMQ=
github.com/ysmood/leakless v0.9.0 h1:qxCG5VirSBvmi3uynXFkcnLMzkphdh3xx5FtrORwDCU=
github.com/ysmood/leakless v0.9.0/go.mod h1:R8iAXPRaG97QJwqxs74RdwzcRHT1SWCGTNqY8q0JvMQ=

0 comments on commit 6458984

Please sign in to comment.