Skip to content

fix(middleware/tracing): replace strings.TrimLeft with strings.CutPrefix for correct fullMethod parsing #3668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(middleware/tracing): replace strings.TrimLeft with strings.CutPrefix for correct fullMethod parsing #3668

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e505ed8
fix(middleware/tracing): replace strings.TrimLeft with strings.CutPre…
May 16, 2025
ec01d30
Merge branch 'main' into middleware/tracing
1911860538 May 16, 2025
767559c
Merge branch 'main' into middleware/tracing
1911860538 Aug 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion middleware/tracing/span.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,11 @@ func setServerSpan(ctx context.Context, span trace.Span, m any) {
// conventions as well as all applicable span attribute.KeyValue attributes based
// on a gRPC's FullMethod.
func parseFullMethod(fullMethod string) (string, []attribute.KeyValue) {
name := strings.TrimLeft(fullMethod, "/")
name, cut := strings.CutPrefix(fullMethod, "/")
if !cut {
// Invalid format, does not follow `/package.service/method`.
return name, []attribute.KeyValue{attribute.Key("rpc.operation").String(fullMethod)}
}
parts := strings.SplitN(name, "/", 2)
if len(parts) != 2 { //nolint:mnd
// Invalid format, does not follow `/package.service/method`.
Expand Down
Loading