break(middleware): update dependencies and improve tracing attributes #3621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
uucloud
force-pushed
the
feat/upgrade_trace_attr
branch
2 times, most recently
from
9d05797 to
76f5064
Compare
dosubot
bot
added
size:M
|
@shenqidebaozi @Cluas Can you help take a look? It's mainly about upgrading otel tracing semconv and replacing deprecated attributes. |
| semconv.NetPeerIPKey.String("127.0.0.1"), | ||
| semconv.NetPeerPortKey.String("8080"), | ||
| semconv.NetworkPeerAddressKey.String("127.0.0.1"), | ||
| semconv.ServerPortKey.Int(8080), |
There was a problem hiding this comment.
Will this result in inconsistent final results, or is it just a change in method name
There was a problem hiding this comment.
will result in inconsistent trace attributes, because some attributes have been deprecated in the latest version of OpenTelemetry and stable attributes have been provided, such as net.peer.ip
uucloud
force-pushed
the
feat/upgrade_trace_attr
branch
from
76f5064 to
41001d1
Compare
uucloud
changed the title
…tracing attributes - Updated `github.com/google/uuid` from v1.4.0 to v1.6.0. - Upgraded OpenTelemetry dependencies to v1.29.0. - Updated `github.com/go-logr/logr` from v1.4.1 to v1.4.2. - Updated `golang.org/x/sys` from v0.18.0 to v0.24.0. - Enhanced tracing attributes in `span.go` and `span_test.go` to include client/server context. - Refactored `peerAttr` function to accept an `isClient` parameter for better attribute handling. - Replaced some deprecated semantic conventions.
uucloud
force-pushed
the
feat/upgrade_trace_attr
branch
from
41001d1 to
31f181d
Compare
shenqidebaozi
previously approved these changes
Apr 24, 2025
|
/hold |
dosubot
bot
added
size:L
|
Upgrading to OpenTelemetry v1.29.0 and replacing deprecated conventions is much needed. The peerAttr refactor with isClient looks good. Curious about any backward compatibility issues and would appreciate more tests if possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (what this PR does / why we need it):
Dependency Updates
Tracing Improvements
These changes ensure our application follows the current best practices for distributed tracing and maintains compatibility with the latest OpenTelemetry standards.