feat(errors): add context support and i18n functionality #3620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add context package import to errors.go - Generate ErrorWithContext function in errorsTemplate.tpl - Implement NewWithContext function in errors/errors.go - Create i18n.go to handle internationalization - Add RegisterI18nManager function for global i18n manager
- Implement mock I18n interface and text formatter - Add tests for NewWithContext when globalI18n is nil and not nil - Verify error creation and localized message functionality
dosubot
bot
added
the
size:L
- Capitalize first letter of error messages in test cases - Ensure consistency in error message formatting
- Replace inline struct initialization with a call to New function - Improve code readability and maintainability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (what this PR does / why we need it):
error adds context support and i18n functionality
Which issue(s) this PR fixes (resolves / be part of):
resolves #3619