Skip to content

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented Jan 12, 2026

Followup #36215, rename the variables for consistency with existing vars and change green to value of --color-blue in the relevant color blind themes:

image

The blue coloring also matched GitHub:

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 12, 2026
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Jan 12, 2026
@silverwind silverwind requested a review from wxiaoguang January 12, 2026 18:03
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 14, 2026
@wxiaoguang
Copy link
Contributor

It seems that GitHub uses orange but not red

image image

@silverwind
Copy link
Member Author

silverwind commented Jan 14, 2026

We could potentially change our red shade in colorblind to a bit more orangey and then also add a color with same hue for --color-diff-removed-fg.

@silverwind silverwind changed the title Rename CSS variables and add blue fg color to colorblind themes Rename CSS variables improve colorblind themes Jan 15, 2026
@silverwind
Copy link
Member Author

silverwind commented Jan 15, 2026

Some tweaks done, still wip. What I don't quite understand is the difference between the two existing colorblind themes. From master:

red-green:
Screenshot 2026-01-15 at 02 02 52
blue-yellow:
image

The only difference is slightly darker red. Both variants can distinguish orange from blue, so I think we can make them look exactly the same.

image

@silverwind
Copy link
Member Author

silverwind commented Jan 15, 2026

Ok should be ready now. Previously the blue-yellow theme imported red-green and then reset red to original red, now I removed this import between the colorblind themes and override only what is actually needed. Here are all 4 themes:

Screenshot 2026-01-15 at 02 23 50 Screenshot 2026-01-15 at 02 23 38 Screenshot 2026-01-15 at 02 23 29 Screenshot 2026-01-15 at 02 23 19

In the future, we could use https://caniuse.com/css-relative-colors to automate such hue rotation, but currently browser support isn't there yet.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 15, 2026
@delvh delvh changed the title Rename CSS variables improve colorblind themes Rename CSS variables and improve colorblind themes Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/templates This PR modifies the template files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants