-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Rename CSS variables and improve colorblind themes #36353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 22b2058.
|
We could potentially change our red shade in colorblind to a bit more orangey and then also add a color with same hue for |
|
Ok should be ready now. Previously the blue-yellow theme imported red-green and then reset red to original red, now I removed this import between the colorblind themes and override only what is actually needed. Here are all 4 themes:
In the future, we could use https://caniuse.com/css-relative-colors to automate such hue rotation, but currently browser support isn't there yet. |









Followup #36215, rename the variables for consistency with existing vars and change green to value of
--color-bluein the relevant color blind themes:The blue coloring also matched GitHub: