Fix the bug when the last code comment deleted, a review comment type comment is still in the activity list of the pull request#35133
Open
lunny wants to merge 8 commits intogo-gitea:mainfrom
Open
Conversation
… comment is still in the activity list of the pull request
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/api
lafriks
approved these changes
Aug 7, 2025
GiteaBot
added
lgtm/need 1
Member
Author
|
last call @go-gitea/technical-oversight-committee |
wxiaoguang
reviewed
Sep 18, 2025
| } | ||
|
|
||
| const json: Record<string, any> = await response.json(); | ||
| if (json.errorMessage) throw new Error(json.errorMessage); |
Contributor
There was a problem hiding this comment.
I think you break a framework design again.
Do you know where the value of "errorMessage" is from? How it should be used? Is it right to use it as an exception(error)?
wxiaoguang
reviewed
Sep 18, 2025
Comment on lines
+156
to
+158
| if (json.deletedReviewCommentHashTag) { | ||
| document.querySelector(`#${json.deletedReviewCommentHashTag}`)?.remove(); | ||
| } |
Contributor
There was a problem hiding this comment.
You can see that the lines around this use the data attributes. So why here it uses a backend-generated ID?
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #29715
Ensure that a review comment with no content is also deleted when its last associated code comment is removed.
Introduced API functionality for deleting code comments.