Run `gopls modernize` on codebase #34751

silverwind · 2025-06-17T17:37:10Z

Continue #33739. I ran modernize 3 times until it had nothing to fix, followed by fmt and fixed one lint issue. 🙏 that CI passes.

Recent modernize fixes: https://github.com/golang/tools/commits/master/gopls/internal/analysis/modernize

silverwind · 2025-06-17T18:00:46Z

Test failure TestChangeRepoFilesForUpdateWithFileRename is unrelated.

lunny · 2025-06-17T18:11:27Z

modules/actions/workflows.go

-						break
-					}
+				if slices.ContainsFunc(actions, glob.MustCompile(val, '/').Match) {
+					matched = true


It can be break directly here.

lunny · 2025-06-17T18:11:41Z

modules/actions/workflows.go

-						break
-					}
+				if slices.ContainsFunc(actions, glob.MustCompile(val, '/').Match) {
+					matched = true


The same as above

silverwind · 2025-06-17T18:13:52Z

BTW feel free to push any changes directly to this branch.

lunny · 2025-06-17T18:18:33Z

routers/install/install.go

-			isCurDBTypeSupported = true
-			break
-		}
+	if slices.Contains(setting.SupportedDatabaseTypes, curDBType) {


The 4 lines could be merged.

lunny · 2025-06-17T18:20:42Z

routers/web/user/code.go

-					find = true
-					break
-				}
+			if slices.Contains(loadRepoIDs, result.RepoID) {


merge the 4 lines

silverwind · 2025-06-17T18:21:15Z

tests/integration/issue_test.go

-	}
+	expectedIssueCount := min(
+		// from the fixtures
+		20, setting.UI.IssuePagingNum)


This formatting is not ideal, I will fix.

services/gitdiff/submodule_test.go

delvh

I agree with @lunny, otherwise LGTM

wxiaoguang · 2025-06-18T00:22:40Z

Please wait for Refactor some file edit related code #34744 , otherwise there will be huge conflicts which are difficult to resolve.

wxiaoguang

It's large enough, and the auto-fixed code is good enough.

Let's leave the manual fixes to the future, to avoid introducing regressions.

wxiaoguang · 2025-06-18T01:35:48Z

tests/integration/issue_test.go

-	}
+	expectedIssueCount := min(
+		// from the fixtures
+		20, setting.UI.IssuePagingNum)


Mark another manual fix (let's do in the following up PRs)

wxiaoguang · 2025-06-18T01:36:04Z

tests/integration/api_issue_test.go

-	}
+	expectedIssueCount := min(
+		// from the fixtures
+		20, setting.UI.IssuePagingNum)


wxiaoguang · 2025-06-18T01:36:07Z

tests/integration/api_issue_test.go

-	}
+	expectedIssueCount := min(
+		// from the fixtures
+		20, setting.UI.IssuePagingNum)


wxiaoguang · 2025-06-18T01:37:28Z

routers/web/explore/code.go

-					break
-				}
+			if slices.Contains(loadRepoIDs, result.RepoID) {
+				find = true


wxiaoguang · 2025-06-18T01:38:27Z

modules/setting/markup.go

@@ -149,8 +149,8 @@ func loadMarkupFrom(rootCfg ConfigProvider) {
 func newMarkupSanitizer(name string, sec ConfigSection) {
 	rule, ok := createMarkupSanitizerRule(name, sec)
 	if ok {
-		if strings.HasPrefix(name, "sanitizer.") {
-			names := strings.SplitN(strings.TrimPrefix(name, "sanitizer."), ".", 2)
+		if after, ok0 := strings.CutPrefix(name, "sanitizer."); ok0 {


a1012112796 · 2025-06-18T02:32:23Z

maybe we can use this tool in ci steps?

lunny · 2025-06-18T02:34:36Z

maybe we can use this tool in ci steps?

gopls is slow enough.

* giteaofficial/main: Remove unused param `doer` (go-gitea#34545) Improve alignment of commit status icon on commit page (go-gitea#34750) Run `gopls modernize` on codebase (go-gitea#34751) Refactor some file edit related code (go-gitea#34744) [skip ci] Updated translations via Crowdin Fix ghost user in feeds when pushing in an actions, it should be gitea-actions (go-gitea#34703) upgrade orgmode to v1.8.0 (go-gitea#34721) Support title and body query parameters for new PRs (go-gitea#34537) Improve nuget/rubygems package registries (go-gitea#34741) Replace update repository function in some places (go-gitea#34566) remove unnecessary duplicate code (go-gitea#34733) fix: prevent double markdown link brackets when pasting URL (go-gitea#34745) Fix JS error for "select" dropdown (go-gitea#34743) [skip ci] Updated translations via Crowdin Allow renaming/moving binary/LFS files in the UI (go-gitea#34350) Clean bindata (go-gitea#34728) Refactor container and UI (go-gitea#34736) Prevent duplicate form submissions when creating forks (go-gitea#34714)

silverwind · 2025-06-18T07:52:33Z

maybe we can use this tool in ci steps?

Yes that is the plan, at least as a initial lint-only step. Once we upgrade gopls, the gopls check command will enforce these fixes. Maybe later, they could be rolled into make fmt.

gopls is slow enough.

Yes, gopls check is slow, but I guess these additional checks won't slow it down much more. Ideally such checks would execute as part of golangci-lint, but first those two projects need to sort out their issues, see golangci/golangci-lint#686 (comment).

Run gopls modernize on codebase

29823e0

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 17, 2025

github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/migrations modifies/internal labels Jun 17, 2025

lunny reviewed Jun 17, 2025

View reviewed changes

silverwind commented Jun 17, 2025

View reviewed changes

lunny reviewed Jun 17, 2025

View reviewed changes

services/gitdiff/submodule_test.go Show resolved Hide resolved

delvh approved these changes Jun 17, 2025

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 17, 2025

Merge branch 'main' into modernize2

341c5e6

Merge branch 'main' into modernize2

57f4e48

wxiaoguang approved these changes Jun 18, 2025

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 18, 2025

wxiaoguang enabled auto-merge (squash) June 18, 2025 01:33

wxiaoguang reviewed Jun 18, 2025

View reviewed changes

tests/integration/api_issue_test.go

}

expectedIssueCount := min(

// from the fixtures

20, setting.UI.IssuePagingNum)

Copy link

Contributor

wxiaoguang Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mark

wxiaoguang reviewed Jun 18, 2025

View reviewed changes

tests/integration/api_issue_test.go

}

expectedIssueCount := min(

// from the fixtures

20, setting.UI.IssuePagingNum)

Copy link

Contributor

wxiaoguang Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mark

wxiaoguang reviewed Jun 18, 2025

View reviewed changes

routers/web/explore/code.go

break

}

if slices.Contains(loadRepoIDs, result.RepoID) {

find = true

Copy link

Contributor

wxiaoguang Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mark

wxiaoguang reviewed Jun 18, 2025

View reviewed changes

wxiaoguang merged commit 1f35435 into go-gitea:main Jun 18, 2025
26 checks passed

GiteaBot added this to the 1.25.0 milestone Jun 18, 2025

wxiaoguang deleted the modernize2 branch June 18, 2025 02:35

Uh oh!

Run gopls modernize on codebase #34751

Run gopls modernize on codebase #34751

Conversation

silverwind commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silverwind commented Jun 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

silverwind commented Jun 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

delvh left a comment

Choose a reason for hiding this comment

Uh oh!

wxiaoguang commented Jun 18, 2025

Uh oh!

wxiaoguang left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

a1012112796 commented Jun 18, 2025

Uh oh!

lunny commented Jun 18, 2025

Uh oh!

silverwind commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Run `gopls modernize` on codebase #34751

Run `gopls modernize` on codebase #34751

silverwind commented Jun 17, 2025 •

edited

Loading

wxiaoguang left a comment •

edited

Loading

silverwind commented Jun 18, 2025 •

edited

Loading