Remove HasWiki method and use IsRepositoryExist

[lunny]

No description provided.

[wxiaoguang]

I think it should stop here.

The design is wrong.

You can't make every function do "for repo" and "for wiki".

Since wiki is also a git repo, it should share the same repo interface as a code repo.

dismiss

[lunny]

last call @go-gitea/technical-oversight-committee

[wxiaoguang]

Is it possible to have a better design to avoid filling the code base with a lot of if err != nil { return err }? This simple PR +119 −44, in the future there will be more if err != nil { return err } and does it make code more readable or maintainable?

[lunny]

Maybe we have two options. One is to store the presence of the wiki in the repo_unit table and retrieve the information from the database each time. The other is to creating a HasWiki function under services/wiki, handle the error internally within this function, and return the result accordingly.

[wxiaoguang]

And I believe we should introduce a better error handling framework.

[wxiaoguang]

For this PR, I do not see why Remove HasWiki method makes sense or brings benefit.

I do not see any feasible plan for the "git repo" related refactoring work.

[lunny]

For this PR, I do not see why Remove HasWiki method makes sense or brings benefit.

I do not see any feasible plan for the "git repo" related refactoring work.

This PR will try to make all other packages just depend on the relative path of the repository except gitrepo package. Now the absolute repository path will be used everywhere which will prevent abstract of repository storage.