Make `ContextPopup` stateless, improve fetching logic #31181

silverwind · 2024-05-30T14:33:49Z

ContextPopup is now a stateless component, accepting only props to render the popup
Loading state is gone, the requests are fast enough to not need a loading state
Error state is gone, we don't need to show any errors on this, imho
Popups now have the tooltip role which enables singleton behaviour, so multiple such popups won't show at the same time (happens when links are close together)
Increased the interactiveBorder to 15px
Tooltip init is now lazy
Repo link in tooltip is now clickable

Fixes: #31161
Helps with: #30275

Popup over existing issue:

Nonexisting issue does not show anything:

I think this is a nice bugfix for 1.22.

web_src/js/features/contextpopup.js

silverwind · 2024-05-31T15:26:08Z

In 434287a I added another data attribute to track the loading state, ensuring this will never issue two GET requests at the same time for the same link, no matter which DOM events trigger on the link.

wxiaoguang · 2024-06-04T15:48:35Z

Sorry but I do not think the change is good enough.

When you'd like to reuse an existing instance, all states should be handled carefully. For example

Hover on #1, then #1 is loading, then hover to #2, should #2 be loading immediately? (I do not see so in this PR)
Hover on #1, then #1 fails due to temp network error. Then re-hover on #1, will it reload?
Hover on #1, then #1 loads, then #1 changes, then re-hover on #1, will it reload?

I do not think it's worth to force it only use one instance.

I strongly prefer the old approach, which is simple enough and doesn't really cause any problem.

silverwind · 2024-06-04T15:53:23Z

I think single instance is preferable because with the increased interactivity border, it's possible to have situations like this:

As for the other questions, I will check. Of course the last hovered instance should always win.

wxiaoguang · 2024-06-04T15:57:09Z

I think single instance is preferable because with the increased interactivity border, it's possible to have situations like this:

I wouldn't say it is a serious problem, and it could be fixed by add some "hiding" code.

silverwind · 2024-06-10T11:00:11Z

The problem with double tooltip can also be seen with the commit status in commit list. I think it could be fixed by adding a singleton="tooltip" during creation, so that only one instance per singleton can show. Currently this mechanism is active when role is tooltip but I think it may need to become more flexible.

wxiaoguang · 2025-03-13T02:34:17Z

Is it sill active? I do not see the edge cases in #31181 (comment) could be addressed clearly.

silverwind · 2025-03-14T10:34:17Z

I strongly prefer the old approach, which is simple enough and doesn't really cause any problem.

The old approach at least causes this problem of cached error state on back button:

#31161 (comment)

Also, a stateless component is much simpler than a stateful one, imho.

wxiaoguang · 2025-10-24T06:29:59Z

-> Fix "ref-issue" handling in markup #35739

wxiaoguang · 2025-10-24T06:53:23Z

web_src/js/features/contextpopup.js

+}
+
+export function initContextPopups() {
+  // TODO: Use MutationObserver to detect newly inserted .ref-issue


We don't need any new MutationObserver now.

My data-global-init framework works pretty well in #35739, and more and more global manually-called init functions can be removed.

How does data-global-init detect new content from edits?

data-global-init is handled by a unique global MutationObserver, explained in Refactor global init code and add more comments #33755

Ok, global shared MutationObserver is also fine.

This is a follow up for go-gitea#35662, and also fix go-gitea#31181, help go-gitea#30275, fix go-gitea#31161

Backport #35739 by wxiaoguang This is a follow up for #35662, and also fix #31181, help #30275, fix #31161 Co-authored-by: wxiaoguang <[email protected]>

pull-request-size bot added the size/L label May 30, 2024

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 30, 2024

github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/js labels May 30, 2024

silverwind changed the title ~~Rewrite context popup to stateless~~ Make ContextPopup stateless May 30, 2024

silverwind mentioned this pull request May 30, 2024

Nonexistent issues get linked in commit messages and comments #30275

Open

silverwind added the backport/v1.22 label May 30, 2024

silverwind marked this pull request as draft May 30, 2024 14:50

silverwind force-pushed the cpop branch from 5bdfd0c to a0567d8 Compare May 30, 2024 14:58

Rewrite context popup to stateless

faeb616

silverwind force-pushed the cpop branch from a0567d8 to faeb616 Compare May 30, 2024 14:58

silverwind marked this pull request as ready for review May 30, 2024 14:59

silverwind added the type/bug label May 30, 2024

silverwind added 2 commits May 30, 2024 17:09

init only once, use tooltip role to enable singleton

758918e

fmt

eaea1e7

silverwind mentioned this pull request May 30, 2024

The PRs link in release page will get network error #31161

Closed

try fix test

3ec74c9

wxiaoguang reviewed May 31, 2024

View reviewed changes

web_src/js/features/contextpopup.js Outdated Show resolved Hide resolved

silverwind added 9 commits May 31, 2024 13:49

just check for _tippy

bc8dcbc

support the case of changing link url

0ec0e43

add comment

d553d4c

also try-catch the GET

c5cde74

move check for ref-external-issue into init

e350fdc

rename init to attach

5323ead

comment

e05b59b

add tracking for loading state

434287a

rename attr

abf514f

turn repo name into a link

9b3a922

silverwind changed the title ~~Make ContextPopup stateless~~ Make ContextPopup stateless, improve fetching logic Jun 3, 2024

yp05327 added this to the 1.23.0 milestone Jun 4, 2024

silverwind requested a review from wxiaoguang June 4, 2024 15:40

delvh approved these changes Jun 12, 2024

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 12, 2024

silverwind marked this pull request as draft June 12, 2024 22:06

wxiaoguang removed the backport/v1.22 label Jun 20, 2024

lunny modified the milestones: 1.23.0, 1.24.0 Sep 7, 2024

wxiaoguang removed this from the 1.24.0 milestone Dec 22, 2024

wxiaoguang added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Mar 13, 2025

wxiaoguang removed their request for review March 23, 2025 15:40

techknowlogick removed the size/L label Apr 10, 2025

wxiaoguang mentioned this pull request Oct 24, 2025

Fix "ref-issue" handling in markup #35739

Merged

wxiaoguang closed this Oct 24, 2025

wxiaoguang reviewed Oct 24, 2025

View reviewed changes

saschazepter pushed a commit to saschazepter/gitea that referenced this pull request Oct 27, 2025

Fix "ref-issue" handling in markup (go-gitea#35739)

cddff73

This is a follow up for go-gitea#35662, and also fix go-gitea#31181, help go-gitea#30275, fix go-gitea#31161

GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 29, 2025

Fix "ref-issue" handling in markup (go-gitea#35739)

6c1b28c

This is a follow up for go-gitea#35662, and also fix go-gitea#31181, help go-gitea#30275, fix go-gitea#31161

GiteaBot mentioned this pull request Oct 29, 2025

Fix "ref-issue" handling in markup (#35739) #35771

Merged

wxiaoguang added a commit that referenced this pull request Oct 29, 2025

Fix "ref-issue" handling in markup (#35739) (#35771)

45a88e0

Backport #35739 by wxiaoguang This is a follow up for #35662, and also fix #31181, help #30275, fix #31161 Co-authored-by: wxiaoguang <[email protected]>

Uh oh!

Uh oh!

Make ContextPopup stateless, improve fetching logic #31181

Make ContextPopup stateless, improve fetching logic #31181

Conversation

silverwind commented May 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

silverwind commented May 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wxiaoguang commented Jun 4, 2024

Uh oh!

silverwind commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wxiaoguang commented Jun 4, 2024

Uh oh!

silverwind commented Jun 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wxiaoguang commented Mar 13, 2025

Uh oh!

silverwind commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wxiaoguang commented Oct 24, 2025

Uh oh!

wxiaoguang Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

silverwind Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wxiaoguang Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

silverwind Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Make `ContextPopup` stateless, improve fetching logic #31181

Make `ContextPopup` stateless, improve fetching logic #31181

silverwind commented May 30, 2024 •

edited

Loading

silverwind commented May 31, 2024 •

edited

Loading

silverwind commented Jun 4, 2024 •

edited

Loading

silverwind commented Jun 10, 2024 •

edited

Loading

silverwind commented Mar 14, 2025 •

edited

Loading

silverwind Oct 27, 2025 •

edited

Loading