Show Release Notification in the UI#27058
Conversation
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
the
modifies/api
|
Hmm, this diverges from the GitHub UI that shows releases only on the frontpage feed (which we already do). I see notifications as "things to do", but a release does not seem to fit here thematically. |
It also sends you an notification
We already sent a Mail, so we could also show it in the UI |
|
|
|
Interesting, I never received a release notification on GH so far. Maybe it's something in my notifications config. I guess once we have that PR landed that enables filtering notifications type per repo, this will be okay to have. |
|
I have a PR to do similar work but not finished and closed. The notification should have more types and users could have filters in future. |
| continue | ||
| } | ||
|
|
||
| release, err := repo_model.GetReleaseByID(ctx, notification.ReleaseID) |
There was a problem hiding this comment.
It's low efficiency. We need to id in () to fix the possible performance problem.
There was a problem hiding this comment.
GetReleaseByID does not more than doing a Database query with the ID. It does not load other things if it's that what you mean.
There was a problem hiding this comment.
You can find many examples to a batch loading. Use a for loop to get all release id and then get all releases use id in () and then assign release to notification.
I have already open #26865 do do exactly that. Backend and tests are ready, but I need some help on the Frontend. |
I can help in UI. what we need to do. |
Thanks. The other PR has a proof of concept UI that already works, but it doesn't look good. Ideally it should look like GitHub. |
will open a pr for the ui. |
| IssueID int64 `xorm:"INDEX NOT NULL"` | ||
| CommitID string `xorm:"INDEX"` | ||
| CommentID int64 | ||
| ReleaseID int64 `xorm:"INDEX"` |
There was a problem hiding this comment.
The Migration will be added after the Code is reviewed.
Co-authored-by: delvh <dev.lh@web.de>
GiteaBot
added
lgtm/need 1
|
Since this is outdated and there are so many conflicted files. This could be replaced by #34803 |
8 participants
If a repo that you are watching creates a new Release, you get a Mail but it is not shown in the UI. This PR changed this. Now the Release Notification is shown in the UI!
The Migration will be added after the Code is reviewed.