Skip to content

Conversation

@trabus
Copy link

@trabus trabus commented Dec 16, 2016

Pulls in imagesloaded via browserify in an instance-initializer, and sets up dependencies in default blueprint.

@trabus
Copy link
Author

trabus commented Dec 28, 2016

I'm uncertain why these two unit tests are failing in only ember 2.8, from what I can see, according to this issue (emberjs/ember.js#12457) it should be failing in all of the ember-try scenarios because stubbing _super isn't technically supported.

@trabus
Copy link
Author

trabus commented Dec 28, 2016

I simply removed the _super check in the tests, since it's unreliable. We can still have a valid test to see if masonry is destroyed or not when the attributes change, and if the value is changing, obviously _super is being called.

@kellyselden
Copy link

I think if you split this PR into an update ember-cli PR and then start the tweaks, it would have better chance at being merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants