fix: Incorrect workspace bindings when disconecting then reconnecting a monitor #1185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1130
When reconnecting to new displays (for example, turning a monitor off and on again, or using Windows + P to switch between extended and single monitor modes), Glaze tries to add the new monitor and bind it according to the config. However, the add_monitor function not only creates a new monitor but also binds workspaces to it. This is incorrect, because the workspaces end up bound to unsorted monitors, causing incorrect index numbers. The fix is to move the binding logic into a new method and only bind workspaces to monitors after they have been sorted.