-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Handle generic object references in forms migrations #21598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle generic object references in forms migrations #21598
Conversation
c86b190 to
8ff70d1
Compare
|
Rebased to fix conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result will not be the same whether the genericobject migration has been processed or not.
The genericobject migration import the plugin items, import the related CommonDBConnexity items, but does not update foreign keys present in other objects classes. Maybe it should.
I expect the generic object migration to be executed first in this case, at least it unlock the situation.
Indeed, but it might not be easy to set up (can you do it for 11.0.2 ?) |
|
I'll wait for #21709 to be merged before fixing conflitcs as it will conflict on the same test file again. |
8ff70d1 to
b9a465c
Compare
b9a465c to
37a25c9
Compare
|
Rebased to fix conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am working on a more global fix to handle update of foreign keys during the genericobject migration.
|
Replaced by #21768 |
Checklist before requesting a review
Description
Formcreator questions may reference data from the generic objects plugin:
Since this plugin is replaced by native custom assets in GLPI 11, we must look for the migrated itemtype instead.
References
Internal support ticket: !39700